From: "Torsten Bögershausen" <tboegi@web•de>
To: "Junio C Hamano" <gitster@pobox•com>,
"Johannes Schindelin" <johannes.schindelin@gmx•de>,
"Torsten Bögershausen" <tboegi@web•de>
Cc: Dan Langille <dlangille@sourcefire•com>,
"brian m. carlson" <sandals@crustytoothpaste•net>,
git@vger•kernel.org
Subject: Re: forcing a user@ into the URL if not present
Date: Wed, 06 May 2015 06:52:32 +0200 [thread overview]
Message-ID: <55499E10.2050003@web.de> (raw)
In-Reply-To: <xmqqmw1iex4m.fsf@gitster.dls.corp.google.com>
On 05/05/2015 07:45 PM, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schindelin@gmx•de> writes:
>
>> Having stumbled over [this
>> ticket](https://github.com/git-for-windows/git/issues/92) recently, it
>> appears to me as if the following should work for you:
>>
>> git clone https://:@repo.example.org/
> Wow.
>
> Is this a windows-only SSPI thing, or is this a widely accepted URL
> convention? I haven't seen anybody use such a URL but I would say
> that is a natural thing to expect to work, as both username and
> password are missing so they should default to some sensible values,
> in this case "current user, shouldn't need password", just like
> "scheme://site:/" is "port missing so it should default to some
> sensible value, appropriate for the scheme".
>
> I think Torsten recently added a bit more test for our URL parsing
> code, especially for "scheme://site:/" (missing port), but I do not
> think we have "scheme://:site/" (missing user or password). Perhaps
> we would want to have additional tests to cover this shape of URL?
>
I have added tests for URL parsing, but for host names/port numbers.
Not for usernames/passwords (passwords shouldn't be there,
recommends RFC 3986)
And only for the ssh:// protocol, as well as git://.
http:// and https:// are not handled by connect.c at all,
and I'm not really familiar with curl, nor kerberos.
In other words: I can not help very much at the moment.
next prev parent reply other threads:[~2015-05-06 5:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 20:06 forcing a user@ into the URL if not present Dan Langille
2015-04-30 20:14 ` Dan Langille
2015-04-30 20:23 ` brian m. carlson
2015-05-04 19:35 ` Dan Langille
2015-05-05 12:35 ` Dan Langille
2015-05-05 13:59 ` Johannes Schindelin
2015-05-05 17:45 ` Junio C Hamano
2015-05-06 4:52 ` Torsten Bögershausen [this message]
2015-05-06 5:29 ` Johannes Schindelin
2015-05-06 17:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55499E10.2050003@web.de \
--to=tboegi@web$(echo .)de \
--cc=dlangille@sourcefire$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=sandals@crustytoothpaste$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox