From: Junio C Hamano <gitster@pobox•com>
To: Johannes Schindelin <johannes.schindelin@gmx•de>
Cc: "Torsten Bögershausen" <tboegi@web•de>,
"Dan Langille" <dlangille@sourcefire•com>,
"brian m. carlson" <sandals@crustytoothpaste•net>,
git@vger•kernel.org
Subject: Re: forcing a user@ into the URL if not present
Date: Wed, 06 May 2015 10:18:18 -0700 [thread overview]
Message-ID: <xmqqsib9bp5x.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <e8793cf6c07dcfcfa835dbc4c438918f@www.dscho.org> (Johannes Schindelin's message of "Wed, 06 May 2015 07:29:20 +0200")
Johannes Schindelin <johannes.schindelin@gmx•de> writes:
>>> I haven't seen anybody use such a URL but I would say that is a
>>> natural thing to expect to work, as both username and password are
>>> missing so they should default to some sensible values, in this
>>> case "current user, shouldn't need password", just like
>>> "scheme://site:/" is "port missing so it should default to some
>>> sensible value, appropriate for the scheme".
>
> Yes, that makes total sense to me, too. In fact, I found it rather
> clever once I got over the surprise.
Yup, I'd happily call that "clever" ;-)
> TBH it does not seem overly urgent to add those tests for the HTTPS
> handling. From a cursory look it seems that neither
> transport_helper_init()` nor any code in `remote-curl.c` parses the
> "<user@password>" part of the URL, or for that matter puts
> restrictions on it.
Thanks for checking.
prev parent reply other threads:[~2015-05-06 17:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 20:06 forcing a user@ into the URL if not present Dan Langille
2015-04-30 20:14 ` Dan Langille
2015-04-30 20:23 ` brian m. carlson
2015-05-04 19:35 ` Dan Langille
2015-05-05 12:35 ` Dan Langille
2015-05-05 13:59 ` Johannes Schindelin
2015-05-05 17:45 ` Junio C Hamano
2015-05-06 4:52 ` Torsten Bögershausen
2015-05-06 5:29 ` Johannes Schindelin
2015-05-06 17:18 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsib9bp5x.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dlangille@sourcefire$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=sandals@crustytoothpaste$(echo .)net \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox