From: Ramsay Jones <ramsay@ramsayjones•plus.com>
To: Jeff King <peff@peff•net>, Dennis Kaarsemaker <dennis@kaarsemaker•net>
Cc: Adam Dinwoodie <adam@dinwoodie•org>,
git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>
Subject: Re: Bug: t5813 failing on Cygwin
Date: Sun, 8 Nov 2015 13:21:37 +0000 [thread overview]
Message-ID: <563F4C61.5040500@ramsayjones.plus.com> (raw)
In-Reply-To: <20151108051059.GB19191@sigill.intra.peff.net>
On 08/11/15 05:10, Jeff King wrote:
> On Sat, Nov 07, 2015 at 10:02:45PM +0100, Dennis Kaarsemaker wrote:
>
>> Looks like lib-proto-disable.sh's fake SSH doesn't strip double leading
>> /'es from the path. Try this patch:
>>
>> diff --git a/t/t5813-proto-disable-ssh.sh b/t/t5813-proto-disable
>> -ssh.sh
>> index ad877d7..a954ead 100755
>> --- a/t/t5813-proto-disable-ssh.sh
>> +++ b/t/t5813-proto-disable-ssh.sh
>> @@ -14,7 +14,7 @@ test_expect_success 'setup repository to clone' '
>> '
>>
>> test_proto "host:path" ssh "remote:repo.git"
>> -test_proto "ssh://" ssh "ssh://remote/$PWD/remote/repo.git"
>> -test_proto "git+ssh://" ssh "git+ssh://remote/$PWD/remote/repo.git"
>> +test_proto "ssh://" ssh "ssh://remote$PWD/remote/repo.git"
>> +test_proto "git+ssh://" ssh "git+ssh://remote$PWD/remote/repo.git"
>>
>> test_done
>
> Good catch. It's a shame that the resulting URL becomes a little less
> readable, but given that the damage is limited to this one test, I think
> we can live with it. Working around it in the fake ssh script would
> probably end up unnecessarily complex.
>
> We may want to have git itself remove extra slashes from URLs, as Ramsay
> suggested elsewhere, but I would worry about regressions. Let's solve
> this test portability problem by itself, and we can consider the other
> as a separate topic if anybody wants to pursue it.
Yep, this is essentially what I decided to do in a similar situation
back in 2011 (see commit 3a81f33c5).
Until I looked into that bug, I hadn't given any thought to whether
cygwin (let alone git) supported the UNC notation. At that time, I did
spend a little time trying to determine if it worked, but for some
reason I just couldn't get a network share configured properly.
It kept on giving me 'permission denied' errors - even using windows
only commands. :(
Since I have no need for network shares on cygwin, I didn't try too
hard ... I will leave it to people more motivated than me! ;-)
ATB,
Ramsay Jones
prev parent reply other threads:[~2015-11-08 13:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 12:11 Bug: t5813 failing on Cygwin Adam Dinwoodie
2015-11-07 18:45 ` Jeff King
2015-11-07 19:20 ` Adam Dinwoodie
2015-11-07 21:02 ` Dennis Kaarsemaker
2015-11-07 21:21 ` Ramsay Jones
2015-11-07 23:05 ` Ramsay Jones
2015-11-07 23:32 ` Dennis Kaarsemaker
2015-11-08 1:46 ` Ramsay Jones
2015-11-08 7:11 ` Torsten Bögershausen
2015-11-07 23:24 ` Adam Dinwoodie
2015-11-08 5:10 ` Jeff King
2015-11-08 9:54 ` [PATCH] t5813: avoid creating urls that break on cygwin Dennis Kaarsemaker
2015-11-09 15:45 ` Jeff King
2015-11-09 17:49 ` Dennis Kaarsemaker
2015-11-09 17:50 ` Jeff King
2015-11-08 13:21 ` Ramsay Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563F4C61.5040500@ramsayjones.plus.com \
--to=ramsay@ramsayjones$(echo .)plus.com \
--cc=adam@dinwoodie$(echo .)org \
--cc=dennis@kaarsemaker$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox