From: Sebastian Schuberth <sschuberth@gmail•com>
To: git@vger•kernel.org
Subject: Re: [PATCH 2/2] contrib/git-candidate: Add README
Date: Wed, 6 Jan 2016 21:50:14 +0100 [thread overview]
Message-ID: <568D7E06.9030100@gmail.com> (raw)
In-Reply-To: <1447160198-23296-3-git-send-email-richard.ipsum@codethink.co.uk>
On 10.11.2015 13:56, Richard Ipsum wrote:
> +Existing tools such as Github's pull-requests and Gerrit are already
> +in wide use, why bother with something new?
> +
> +We are concerned that whilst git is a distributed version control
> +system the systems used to store comments and reviews for content
> +under version control are usually centralised,
I think it's a bit unjust to unconditionally mention Gerrit in this
context as you seem to imply that Gerrit does not store *any* review
data in Git.
Even without Dave's upcoming notedb, Gerrit already stores refs/changes
in Git, and with the reviewnotes plugin [1] also the outcome of a review
in refs/notes/review.
[1]
https://gerrit.googlesource.com/plugins/reviewnotes/+/refs/heads/master/src/main/resources/Documentation/refs-notes-review.md
--
Sebastian Schuberth
next prev parent reply other threads:[~2016-01-06 20:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 12:56 [PATCH 0/2] git-candidate: git based patch tracking and review Richard Ipsum
2015-11-10 12:56 ` [PATCH 1/2] contrib: Add git-candidate subcommand Richard Ipsum
2015-11-10 12:56 ` [PATCH 2/2] contrib/git-candidate: Add README Richard Ipsum
2015-11-10 20:19 ` David Turner
2015-11-11 9:48 ` Richard Ipsum
2015-11-11 20:15 ` David Turner
2016-01-06 20:50 ` Sebastian Schuberth [this message]
2015-11-11 9:55 ` [PATCH 0/2] git-candidate: git based patch tracking and review Michael Haggerty
2015-11-11 15:12 ` Richard Ipsum
2015-11-14 8:17 ` Jeff King
2015-11-14 13:07 ` Junio C Hamano
2015-12-01 20:55 ` Jonathan Nieder
2015-12-01 21:00 ` Dave Borowitz
2016-01-06 15:49 ` Richard Ipsum
-- strict thread matches above, loose matches on Subject: below --
2015-10-14 17:30 [RFC] Git " Richard Ipsum
2015-10-14 17:30 ` [PATCH 2/2] contrib/git-candidate: Add README Richard Ipsum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568D7E06.9030100@gmail.com \
--to=sschuberth@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox