From: Kazutoshi Satoda <k_satoda@f2•dion.ne.jp>
To: git@vger•kernel.org
Cc: normalperson@yhbt•net, alex.crezoff@gmail•com
Subject: [PATCH 1/2] git-svn: enable "svn.pathnameencoding" on dcommit
Date: Tue, 9 Feb 2016 00:20:31 +0900 [thread overview]
Message-ID: <56B8B23F.2020901@f2.dion.ne.jp> (raw)
In-Reply-To: <56B8B1EA.5020901@f2.dion.ne.jp>
Without the initialization of $self->{pathnameencoding}, conversion in
repo_path() is always skipped as $self->{pathnameencoding} is undefined
even if "svn.pathnameencoding" is configured.
The lack of conversion results in mysterious failure of dcommit (e.g.
"Malformed XML") which happen only when a commit involves a change on
non-ASCII path.
Signed-off-by: Kazutoshi SATODA <k_satoda@f2•dion.ne.jp>
---
perl/Git/SVN/Editor.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/perl/Git/SVN/Editor.pm b/perl/Git/SVN/Editor.pm
index c50176e..d9d9bdf 100644
--- a/perl/Git/SVN/Editor.pm
+++ b/perl/Git/SVN/Editor.pm
@@ -41,6 +41,7 @@ sub new {
"$self->{svn_path}/" : '';
$self->{config} = $opts->{config};
$self->{mergeinfo} = $opts->{mergeinfo};
+ $self->{pathnameencoding} = Git::config('svn.pathnameencoding');
return $self;
}
--
2.7.0
next prev parent reply other threads:[~2016-02-08 15:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 15:19 [PATCH 0/2] enable "svn.pathnameencoding" on dcommit Kazutoshi Satoda
2016-02-08 15:20 ` Kazutoshi Satoda [this message]
2016-02-15 0:30 ` [PATCH 1/2] git-svn: " Eric Wong
2016-02-08 15:21 ` [PATCH 2/2] git-svn: apply "svn.pathnameencoding" before URL encoding Kazutoshi Satoda
2016-02-15 0:33 ` Eric Wong
2016-02-08 22:58 ` [PATCH 0/2] enable "svn.pathnameencoding" on dcommit Eric Wong
2016-02-15 0:52 ` [PULL] svn pathnameencoding for git svn dcommit Eric Wong
2016-02-15 21:32 ` Junio C Hamano
2016-02-16 3:29 ` Kazutoshi Satoda
2016-02-16 6:33 ` Eric Wong
2016-02-16 16:19 ` Kazutoshi Satoda
2016-02-20 23:37 ` Eric Wong
2016-02-21 13:12 ` Kazutoshi Satoda
2016-02-27 18:28 ` [PATCH 1/1] t9115: Skip pathnameencoding=cp932 under HFS tboegi
2016-02-28 4:59 ` Eric Wong
2016-02-28 17:52 ` Torsten Bögershausen
2016-03-15 1:59 ` Eric Wong
2016-03-15 5:23 ` Torsten Bögershausen
2016-03-15 7:09 ` Eric Wong
2016-03-16 17:37 ` Kazutoshi Satoda
2016-03-17 5:16 ` Torsten Bögershausen
2016-03-17 5:35 ` Torsten Bögershausen
2016-03-18 2:15 ` Kazutoshi Satoda
2016-03-19 6:59 ` Torsten Bögershausen
2016-03-18 2:14 ` Kazutoshi Satoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B8B23F.2020901@f2.dion.ne.jp \
--to=k_satoda@f2$(echo .)dion.ne.jp \
--cc=alex.crezoff@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=normalperson@yhbt$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox