From: Kazutoshi Satoda <k_satoda@f2•dion.ne.jp>
To: "Eric Wong" <normalperson@yhbt•net>,
"Torsten Bögershausen" <tboegi@web•de>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 1/1] t9115: Skip pathnameencoding=cp932 under HFS
Date: Thu, 17 Mar 2016 02:37:07 +0900 [thread overview]
Message-ID: <56E999C3.4040802@f2.dion.ne.jp> (raw)
In-Reply-To: <20160315070930.GA24036@dcvr.yhbt.net>
On 2016/03/15 16:09 +0900, Eric Wong wrote:
> Torsten Bögershausen <tboegi@web•de> wrote:
>> On 03/15/2016 02:59 AM, Eric Wong wrote:
>> >[]
>> >I just edited locally and pushed those out to Junio:
>> >
>> >http://mid.gmane.org/20160315015726.GA25295@dcvr.yhbt.net
>> >
>>
>> The new TC 11/12 don't pass under cygwin.
>>
>> Do we need cp932 ?
>
> Not sure, both CP932 and ISO8859-1 work fine for me on
> GNU/Linux. Anyways I'm fine skipping this patch for 2.8
> while we hash it out, too.
>
> Kazutoshi: can you answer? Thanks.
I tried the patch. The test works (pass with my fixes, and fails
without fixes) with ISO8859-1 for me on Cygnus. The change sounds
good.
>> If not, we may use the paych from here:
>> https://github.com/tboegi/git/commit/379c01bf52464f8a50065b11af516127e9144045
>>
>> Date: Tue Mar 15 05:03:18 2016 +0100
>>
>> t9115: Use funcky file names that work under unicode FS
"funcky" looks a typo.
>> Don't use funky file names, that can not be created under
>> HFS or NTFS.
The file can be created on my Cygnus environment, which is under FONTS.
So it looks a bit inaccurate.
I think a quote from the actual error message may be useful. It will
likely tell what was wrong, accurately. And also, someone may search for
that message.
>> - neq=$(printf "\201\202") &&
>> - git config svn.pathnameencoding cp932 &&
>> + neq=$(printf "\303\244") &&
>> + git config svn.pathnameencoding ISO8859-1 &&
The variable name "new" was for "NOT EQUAL TO" (0x8182 in cp932 = U+2260).
http://unicode.org/Public/MAPPINGS/VENDORS/MICSFT/WINDOWS/CP932.TXT
Then it should be changed, too. A more abstract one may be appropriate.
>> - inf=$(printf "\201\207") &&
>> - git config svn.pathnameencoding cp932 &&
>> + inf=$(printf "\303\226") &&
>> + git config svn.pathnameencoding ISO8859-1 &&
Ditto. (0x8187 in cp932 = U+221E, INFINITY)
--
k_satoda
next prev parent reply other threads:[~2016-03-16 17:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 15:19 [PATCH 0/2] enable "svn.pathnameencoding" on dcommit Kazutoshi Satoda
2016-02-08 15:20 ` [PATCH 1/2] git-svn: " Kazutoshi Satoda
2016-02-15 0:30 ` Eric Wong
2016-02-08 15:21 ` [PATCH 2/2] git-svn: apply "svn.pathnameencoding" before URL encoding Kazutoshi Satoda
2016-02-15 0:33 ` Eric Wong
2016-02-08 22:58 ` [PATCH 0/2] enable "svn.pathnameencoding" on dcommit Eric Wong
2016-02-15 0:52 ` [PULL] svn pathnameencoding for git svn dcommit Eric Wong
2016-02-15 21:32 ` Junio C Hamano
2016-02-16 3:29 ` Kazutoshi Satoda
2016-02-16 6:33 ` Eric Wong
2016-02-16 16:19 ` Kazutoshi Satoda
2016-02-20 23:37 ` Eric Wong
2016-02-21 13:12 ` Kazutoshi Satoda
2016-02-27 18:28 ` [PATCH 1/1] t9115: Skip pathnameencoding=cp932 under HFS tboegi
2016-02-28 4:59 ` Eric Wong
2016-02-28 17:52 ` Torsten Bögershausen
2016-03-15 1:59 ` Eric Wong
2016-03-15 5:23 ` Torsten Bögershausen
2016-03-15 7:09 ` Eric Wong
2016-03-16 17:37 ` Kazutoshi Satoda [this message]
2016-03-17 5:16 ` Torsten Bögershausen
2016-03-17 5:35 ` Torsten Bögershausen
2016-03-18 2:15 ` Kazutoshi Satoda
2016-03-19 6:59 ` Torsten Bögershausen
2016-03-18 2:14 ` Kazutoshi Satoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E999C3.4040802@f2.dion.ne.jp \
--to=k_satoda@f2$(echo .)dion.ne.jp \
--cc=git@vger$(echo .)kernel.org \
--cc=normalperson@yhbt$(echo .)net \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox