public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Ramsay Jones <ramsay@ramsayjones•plus.com>
To: Stefan Beller <stefanbeller@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>,
	GIT Mailing-list <git@vger•kernel.org>
Subject: [PATCH] submodule--helper: fix 'dubious bitfield' sparse warnings
Date: Thu, 25 Feb 2016 19:42:00 +0000	[thread overview]
Message-ID: <56CF5908.7090800@ramsayjones.plus.com> (raw)


Signed-off-by: Ramsay Jones <ramsay@ramsayjones•plus.com>
---

Hi Stefan,

If you need to re-roll (err, one of your) 'sb/submodule-parallel-update'
branches, could you please squash this into the relevant patch.
(ie. "git submodule update: have a dedicated helper for cloning", 23-02-2016).

Thanks!

ATB,
Ramsay Jones

 builtin/submodule--helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index f8cdce9..482a3cc 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -563,7 +563,7 @@ struct submodule_update_clone {
 	/* index into 'list', the list of submodules to look into for cloning */
 	int current;
 	struct module_list list;
-	int warn_if_uninitialized : 1;
+	unsigned int warn_if_uninitialized : 1;
 	/* update parameter passed via commandline*/
 	struct submodule_update_strategy update;
 	/* configuration parameters which are passed on to the children */
@@ -575,7 +575,7 @@ struct submodule_update_clone {
 	/* lines to be output */
 	struct string_list projectlines;
 	/* If we want to stop as fast as possible and return an error */
-	int quickstop : 1;
+	unsigned int quickstop : 1;
 };
 #define SUBMODULE_UPDATE_CLONE_INIT {0, MODULE_LIST_INIT, 0, \
 	SUBMODULE_UPDATE_STRATEGY_INIT, 0, NULL, NULL, NULL, NULL, \
-- 
2.7.0

next             reply	other threads:[~2016-02-25 19:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25 19:42 Ramsay Jones [this message]
2016-02-25 20:28 ` [PATCH] submodule--helper: fix 'dubious bitfield' sparse warnings Stefan Beller

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:f8cdce9 dfblob:482a3cc )
 OR (
bs:"[PATCH] submodule--helper: fix 'dubious bitfield' sparse warnings" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CF5908.7090800@ramsayjones.plus.com \
    --to=ramsay@ramsayjones$(echo .)plus.com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=stefanbeller@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox