* [PATCH] submodule--helper: fix 'dubious bitfield' sparse warnings
@ 2016-02-25 19:42 Ramsay Jones
2016-02-25 20:28 ` Stefan Beller
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2016-02-25 19:42 UTC (permalink / raw)
To: Stefan Beller; +Cc: Junio C Hamano, GIT Mailing-list
Signed-off-by: Ramsay Jones <ramsay@ramsayjones•plus.com>
---
Hi Stefan,
If you need to re-roll (err, one of your) 'sb/submodule-parallel-update'
branches, could you please squash this into the relevant patch.
(ie. "git submodule update: have a dedicated helper for cloning", 23-02-2016).
Thanks!
ATB,
Ramsay Jones
builtin/submodule--helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index f8cdce9..482a3cc 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -563,7 +563,7 @@ struct submodule_update_clone {
/* index into 'list', the list of submodules to look into for cloning */
int current;
struct module_list list;
- int warn_if_uninitialized : 1;
+ unsigned int warn_if_uninitialized : 1;
/* update parameter passed via commandline*/
struct submodule_update_strategy update;
/* configuration parameters which are passed on to the children */
@@ -575,7 +575,7 @@ struct submodule_update_clone {
/* lines to be output */
struct string_list projectlines;
/* If we want to stop as fast as possible and return an error */
- int quickstop : 1;
+ unsigned int quickstop : 1;
};
#define SUBMODULE_UPDATE_CLONE_INIT {0, MODULE_LIST_INIT, 0, \
SUBMODULE_UPDATE_STRATEGY_INIT, 0, NULL, NULL, NULL, NULL, \
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] submodule--helper: fix 'dubious bitfield' sparse warnings
2016-02-25 19:42 [PATCH] submodule--helper: fix 'dubious bitfield' sparse warnings Ramsay Jones
@ 2016-02-25 20:28 ` Stefan Beller
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Beller @ 2016-02-25 20:28 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Stefan Beller, Junio C Hamano, GIT Mailing-list
On Thu, Feb 25, 2016 at 11:42 AM, Ramsay Jones
<ramsay@ramsayjones•plus.com> wrote:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones•plus.com>
> ---
>
> Hi Stefan,
>
> If you need to re-roll (err, one of your) 'sb/submodule-parallel-update'
> branches, could you please squash this into the relevant patch.
> (ie. "git submodule update: have a dedicated helper for cloning", 23-02-2016).
>
> Thanks!
It's part of v17 already.
Thanks,
Stefan
>
> ATB,
> Ramsay Jones
>
> builtin/submodule--helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index f8cdce9..482a3cc 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -563,7 +563,7 @@ struct submodule_update_clone {
> /* index into 'list', the list of submodules to look into for cloning */
> int current;
> struct module_list list;
> - int warn_if_uninitialized : 1;
> + unsigned int warn_if_uninitialized : 1;
> /* update parameter passed via commandline*/
> struct submodule_update_strategy update;
> /* configuration parameters which are passed on to the children */
> @@ -575,7 +575,7 @@ struct submodule_update_clone {
> /* lines to be output */
> struct string_list projectlines;
> /* If we want to stop as fast as possible and return an error */
> - int quickstop : 1;
> + unsigned int quickstop : 1;
> };
> #define SUBMODULE_UPDATE_CLONE_INIT {0, MODULE_LIST_INIT, 0, \
> SUBMODULE_UPDATE_STRATEGY_INIT, 0, NULL, NULL, NULL, NULL, \
> --
> 2.7.0
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-25 20:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-25 19:42 [PATCH] submodule--helper: fix 'dubious bitfield' sparse warnings Ramsay Jones
2016-02-25 20:28 ` Stefan Beller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox