From: "Christoph Sommer via GitGitGadget" <gitgitgadget@gmail•com>
To: git@vger•kernel.org
Cc: Johannes Sixt <j6t@kdbg•org>,
Christoph Sommer <sommer@cms-labs•org>,
Christoph Sommer <sommer@cms-labs•org>
Subject: [PATCH 1/3] gitk: fix text wrapping preferences for unthemed tk
Date: Mon, 28 Apr 2025 15:56:11 +0000 [thread overview]
Message-ID: <59a6d8831a75f793aae087bbffa9325f09af246a.1745855773.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1909.git.1745855773.gitgitgadget@gmail.com>
From: Christoph Sommer <sommer@cms-labs•org>
Use a widget factory that works for both plain Tk and themed Tk.
Signed-off-by: Christoph Sommer <sommer@cms-labs•org>
---
gitk-git/gitk | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index bc9efa18566..8cb17f39d41 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -11767,13 +11767,11 @@ proc prefspage_general {notebook} {
grid x $page.tabstopl $page.tabstop -sticky w
${NS}::label $page.wrapcommentl -text [mc "Wrap comment text"]
- ${NS}::combobox $page.wrapcomment -values {none char word} -state readonly \
- -textvariable wrapcomment
+ makedroplist $page.wrapcomment wrapcomment "none" "char" "word"
grid x $page.wrapcommentl $page.wrapcomment -sticky w
${NS}::label $page.wrapdefaultl -text [mc "Wrap other text"]
- ${NS}::combobox $page.wrapdefault -values {none char word} -state readonly \
- -textvariable wrapdefault
+ makedroplist $page.wrapdefault wrapdefault "none" "char" "word"
grid x $page.wrapdefaultl $page.wrapdefault -sticky w
${NS}::checkbutton $page.ntag -text [mc "Display nearby tags/heads"] \
--
gitgitgadget
next prev parent reply other threads:[~2025-04-28 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 15:56 [PATCH 0/3] gitk: small quality of life improvements for themed Tk Christoph Sommer via GitGitGadget
2025-04-28 15:56 ` Christoph Sommer via GitGitGadget [this message]
2025-04-28 15:56 ` [PATCH 2/3] gitk: do not set fg/bg color scheme " Christoph Sommer via GitGitGadget
2025-04-28 15:56 ` [PATCH 3/3] gitk: on themed tk, use uicolor to draw a sash between panes Christoph Sommer via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59a6d8831a75f793aae087bbffa9325f09af246a.1745855773.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
--cc=sommer@cms-labs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox