From: "Christoph Sommer via GitGitGadget" <gitgitgadget@gmail•com>
To: git@vger•kernel.org
Cc: Johannes Sixt <j6t@kdbg•org>, Christoph Sommer <sommer@cms-labs•org>
Subject: [PATCH 0/3] gitk: small quality of life improvements for themed Tk
Date: Mon, 28 Apr 2025 15:56:10 +0000 [thread overview]
Message-ID: <pull.1909.git.1745855773.gitgitgadget@gmail.com> (raw)
These three closely related patches build on
https://lore.kernel.org/git/pull.1835.git.1733767737.gitgitgadget@gmail.com
to:
1. also allow changing text wrapping preferences for users that do not use
themed Tk (that is, users that have turned the "use themed widgets"
preference off);
2. no longer change the background color when using themed Tk (the default)
as - at least on the platforms I tried - most widgets and the main
window do not change their background color anyhow, whereas some widgets
do, leading to a messy looking UI where different widgets seemingly
assume different background colors; and
3. use the now-available uicolor preference to draw a "sash" (grab handle)
between the many panes of the main window when using themed Tk; on the
platforms I tried, themed Tk was both the default and it was not
rendering any sash, thus requiring users to guess where to click to
resize window panes. Manually setting uicolor to a platform-dependent
color (see https://www.tcl-lang.org/man/tcl/TkCmd/colors.htm#M4) in the
config file works to get sashes that automatically adapt to light mode
and dark mode.
Christoph Sommer (3):
gitk: fix text wrapping preferences for unthemed tk
gitk: do not set fg/bg color scheme for themed Tk
gitk: on themed tk, use uicolor to draw a sash between panes
gitk-git/gitk | 60 +++++++++++++++++++++++++++++++++++++++++++++------
1 file changed, 53 insertions(+), 7 deletions(-)
base-commit: f65182a99e545d2f2bc22e6c1c2da192133b16a3
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1909%2Fsommer%2Fmaster-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1909/sommer/master-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1909
--
gitgitgadget
next reply other threads:[~2025-04-28 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 15:56 Christoph Sommer via GitGitGadget [this message]
2025-04-28 15:56 ` [PATCH 1/3] gitk: fix text wrapping preferences for unthemed tk Christoph Sommer via GitGitGadget
2025-04-28 15:56 ` [PATCH 2/3] gitk: do not set fg/bg color scheme for themed Tk Christoph Sommer via GitGitGadget
2025-04-28 15:56 ` [PATCH 3/3] gitk: on themed tk, use uicolor to draw a sash between panes Christoph Sommer via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1909.git.1745855773.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
--cc=sommer@cms-labs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox