From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Alyssa Ross" <hi@alyssa•is>, git@vger•kernel.org
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>,
"Junio C Hamano" <gitster@pobox•com>
Subject: Re: [PATCH] receive-pack: fix updateInstead with core.worktree
Date: Fri, 22 May 2026 18:21:07 +0200 [thread overview]
Message-ID: <60a0ec9b-0263-42f5-83b1-c55275c7772a@app.fastmail.com> (raw)
In-Reply-To: <20260522154418.5883-1-hi@alyssa.is>
On Fri, May 22, 2026, at 17:44, Alyssa Ross wrote:
> This used to work, but when push_to_checkout() started being called
> before push_to_deploy(), push_to_checkout()'s side effect of adding
> GIT_WORK_TREE to the same environment that would be used by
> push_to_deploy() wasn't taken into account. Fix by only mutating the
> environment for push_to_commit(), rather than the shared environment.
>
> Fixes: a8cc594333 ("hooks: fix an obscure TOCTOU "did we just run a hook?" race")
This project doesn’t use `Fixes` trailers.[1] Mentions of commits go in
the commit message body (outside the trailers) using `git log -1
--format-reference <cmt>`.
The Linux project has uses for this structured information since there
is a lot of backporting of bugfixes. But I haven’t heard of a need for
that in this project.
🔗 1: https://lore.kernel.org/git/72839071-153f-4306-a705-3be0dc203109@app.fastmail.com/
> Signed-off-by: Alyssa Ross <hi@alyssa•is>
> ---
>[snip]
next prev parent reply other threads:[~2026-05-22 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 15:44 [PATCH] receive-pack: fix updateInstead with core.worktree Alyssa Ross
2026-05-22 16:21 ` Kristoffer Haugsbakk [this message]
2026-05-25 0:20 ` Junio C Hamano
2026-05-25 16:23 ` [PATCH v2] " Alyssa Ross
2026-05-25 22:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60a0ec9b-0263-42f5-83b1-c55275c7772a@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=hi@alyssa$(echo .)is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox