From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Josh Soref" <gitgitgadget@gmail•com>, git@vger•kernel.org
Cc: "Junio C Hamano" <gitster@pobox•com>,
"Derrick Stolee" <stolee@gmail•com>
Subject: Re: [PATCH] diff: avoid segfault with freed entries
Date: Tue, 30 Dec 2025 17:11:09 +0100 [thread overview]
Message-ID: <66032fff-654f-4c46-a7d4-e80d594f2df3@app.fastmail.com> (raw)
In-Reply-To: <pull.2027.git.1767044697712.gitgitgadget@gmail.com>
On Mon, Dec 29, 2025, at 22:44, Derrick Stolee via GitGitGadget wrote:
> From: Derrick Stolee <stolee@gmail•com>
>
>[snip]
> The more elaborate explanation is that within diffcore_std(), we may
> skip the initial prefetch due to the output format (--name-only in the
> test) and go straight to diffcore_skip_stat_unmatch(). In that method,
> the index entries that have been invalidated by path changes show up as
> entries but may be deleted because they are not actually content diffs
> and only newer timestamps than expected. As those entries are deleted,
> later entries are checked with diff_filespec_check_stat_unmatch(), which
> uses diff_queued_diff_prefetch() as the missing_object_cb in its diff
> options. That can trigger downloading missing objects if the appropriate
> scenario occurs to trigger a call to diff_popoulate_filespec(). It's
s/diff_popoulate_filespec/diff_populate_filespec/
> finally within that callback to diff_queued_diff_prefetch() that the
> segfault occurs.
>
>[snip]
prev parent reply other threads:[~2025-12-30 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 21:44 [PATCH] diff: avoid segfault with freed entries Derrick Stolee via GitGitGadget
2025-12-30 4:38 ` Junio C Hamano
2025-12-30 16:11 ` Kristoffer Haugsbakk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66032fff-654f-4c46-a7d4-e80d594f2df3@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=gitster@pobox$(echo .)com \
--cc=stolee@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox