From: Junio C Hamano <gitster@pobox•com>
To: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail•com>
Cc: git@vger•kernel.org, Derrick Stolee <stolee@gmail•com>
Subject: Re: [PATCH] diff: avoid segfault with freed entries
Date: Tue, 30 Dec 2025 13:38:30 +0900 [thread overview]
Message-ID: <xmqqtsx8h9dl.fsf@gitster.g> (raw)
In-Reply-To: <pull.2027.git.1767044697712.gitgitgadget@gmail.com> (Derrick Stolee via GitGitGadget's message of "Mon, 29 Dec 2025 21:44:57 +0000")
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail•com> writes:
> The more elaborate explanation is that within diffcore_std(), we may
> skip the initial prefetch due to the output format (--name-only in the
> test) and go straight to diffcore_skip_stat_unmatch().
That's very interesting. We have code to fetch on-demand when it
turns out that the initial prefetch shouldn't have been skipped and
we need contents, so in that sense, the condition to skip the
initial prefetch does not have to be precise, but we may want to see
if we can have a single helper function that exactly tells us if we
need to look at the contents or not. I think we had a few changes
that made the definition of "diff status is based on contents" in
the past few releases, not for the purpose of this prefetch skipping
but to set the exit status.
next prev parent reply other threads:[~2025-12-30 4:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 21:44 [PATCH] diff: avoid segfault with freed entries Derrick Stolee via GitGitGadget
2025-12-30 4:38 ` Junio C Hamano [this message]
2025-12-30 16:11 ` Kristoffer Haugsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtsx8h9dl.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=stolee@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox