From: Junio C Hamano <gitster@pobox•com>
To: Jens Lehmann <Jens.Lehmann@web•de>
Cc: Git Mailing List <git@vger•kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx•de>
Subject: Re: [PATCH 2/2] Submodules: Use "ignore" settings from .gitmodules too for diff and status
Date: Wed, 28 Jul 2010 14:35:01 -0700 [thread overview]
Message-ID: <7vhbjjware.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4C4DD3CF.9070906@web.de> (Jens Lehmann's message of "Mon\, 26 Jul 2010 20\:28\:31 +0200")
Jens Lehmann <Jens.Lehmann@web•de> writes:
> The .gitmodules file is parsed for "submodule.<name>.ignore" entries
> before looking for them in .git/config. Thus settings found in .git/config
> will override those from .gitmodules,...
Hmph.
The value of "submodule.<name>.path" does not have to be "<name>". There
seems to be a bit of confusion here.
I thought that [PATCH 1/2] used the path to the submodule, not its name,
as the key. Even though the patch to Documentation/config.txt talks about
"submodule.<submodulename>.ignore", what the code actually seems to do in
set-from-submodule-config is to use path.
But this patch seems to key off of <name>.
I suspect that it would make more sense to use <name> so that once the
user configures ignore in .git/config, it will persist across moving of
the submodule in the superproject tree.
In either case, we would want to be consistent between the two, no?
next prev parent reply other threads:[~2010-07-28 21:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 18:26 [PATCH 0/2] Submodules: Add the new config option "ignore" Jens Lehmann
2010-07-26 18:27 ` [PATCH 1/2] Submodules: Add the new "ignore" config option for diff and status Jens Lehmann
2010-07-26 18:28 ` [PATCH 2/2] Submodules: Use "ignore" settings from .gitmodules too " Jens Lehmann
2010-07-28 21:35 ` Junio C Hamano [this message]
2010-08-05 22:37 ` [PATCH v2 0/2] Submodules: Add the new config option "ignore" Jens Lehmann
2010-08-05 22:39 ` [PATCH v2 1/2] Submodules: Add the new "ignore" config option for diff and status Jens Lehmann
2010-08-05 22:40 ` [PATCH v2 2/2] Submodules: Use "ignore" settings from .gitmodules too " Jens Lehmann
2010-08-05 23:27 ` [PATCH v2 0/2] Submodules: Add the new config option "ignore" Junio C Hamano
2010-08-05 23:51 ` Jens Lehmann
2010-08-09 16:57 ` Junio C Hamano
2010-08-05 9:21 ` [PATCH " Johannes Schindelin
2010-08-05 16:49 ` Junio C Hamano
2010-08-05 19:08 ` Jens Lehmann
2010-08-05 23:27 ` [PATCH] Add tests for the diff.ignoreSubmodules config option Jens Lehmann
2010-08-09 16:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhbjjware.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=Jens.Lehmann@web$(echo .)de \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox