public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Jens Lehmann <Jens.Lehmann@web•de>
Cc: Git Mailing List <git@vger•kernel.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx•de>
Subject: Re: [PATCH v2 0/2] Submodules: Add the new config option "ignore"
Date: Thu, 05 Aug 2010 16:27:30 -0700	[thread overview]
Message-ID: <7vvd7obpy5.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4C5B3D36.1060902@web.de> (Jens Lehmann's message of "Fri\, 06 Aug 2010 00\:37\:42 +0200")

Jens Lehmann <Jens.Lehmann@web•de> writes:

> Am 28.07.2010 23:35, schrieb Junio C Hamano:
>> Jens Lehmann <Jens.Lehmann@web•de> writes:
>> 
>>> The .gitmodules file is parsed for "submodule.<name>.ignore" entries
>>> before looking for them in .git/config. Thus settings found in .git/config
>>> will override those from .gitmodules,...
>> 
>> Hmph.
>> 
>> The value of "submodule.<name>.path" does not have to be "<name>".  There
>> seems to be a bit of confusion here.
>
> Thanks for clearing up my confusion, this is v2 of this patch using the
> path configured for the submodule instead of its name.

Hmph, I thought that it would make more sense to use <name> so that once
the user configures ignore in .git/config, it will persist across moving
of the submodule in the superproject tree.  I wonder what others would
think.

Will queue, anyway.

Thanks.

next prev parent reply	other threads:[~2010-08-05 23:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-26 18:26 [PATCH 0/2] Submodules: Add the new config option "ignore" Jens Lehmann
2010-07-26 18:27 ` [PATCH 1/2] Submodules: Add the new "ignore" config option for diff and status Jens Lehmann
2010-07-26 18:28 ` [PATCH 2/2] Submodules: Use "ignore" settings from .gitmodules too " Jens Lehmann
2010-07-28 21:35   ` Junio C Hamano
2010-08-05 22:37     ` [PATCH v2 0/2] Submodules: Add the new config option "ignore" Jens Lehmann
2010-08-05 22:39       ` [PATCH v2 1/2] Submodules: Add the new "ignore" config option for diff and status Jens Lehmann
2010-08-05 22:40       ` [PATCH v2 2/2] Submodules: Use "ignore" settings from .gitmodules too " Jens Lehmann
2010-08-05 23:27       ` Junio C Hamano [this message]
2010-08-05 23:51         ` [PATCH v2 0/2] Submodules: Add the new config option "ignore" Jens Lehmann
2010-08-09 16:57           ` Junio C Hamano
2010-08-05  9:21 ` [PATCH " Johannes Schindelin
2010-08-05 16:49   ` Junio C Hamano
2010-08-05 19:08     ` Jens Lehmann
2010-08-05 23:27       ` [PATCH] Add tests for the diff.ignoreSubmodules config option Jens Lehmann
2010-08-09 16:57         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vvd7obpy5.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox$(echo .)com \
    --cc=Jens.Lehmann@web$(echo .)de \
    --cc=Johannes.Schindelin@gmx$(echo .)de \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox