public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: "Дилян Палаузов" <dilyan.palauzov@aegee•org>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>, git@vger•kernel.org
Subject: Re: 1.7.9, libcharset missing from EXTLIBS
Date: Fri, 10 Feb 2012 10:35:12 -0800	[thread overview]
Message-ID: <7vipjer0yn.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4F34EF9D.8030509@aegee.org> ("Дилян Палаузов"'s message of "Fri, 10 Feb 2012 11:21:17 +0100")

Дилян Палаузов <dilyan.palauzov@aegee•org> writes:

>>> What I am wondering is there are systems that need to include the header,
>>> but locale_charset() does not live in /lib/libcharset.a, in which case we
>>> cannot make HAVE_LIBCHARSET_H imply use of -lcharset.
>
> I do not understand this.  If you want to use a function from
> libcharset, you have to use both #include <libcharset.h> and
> -lcharset.

You are mistaken.

The only constraint is that you have to "#include <libcharset.h>" and need
to link with the library that has locale_charset() defined.  Does everybody
has that function in -lcharset, or a system you do not know have it in some
other library?

For example, Msysgit part defines HAVE_LIBCHARSET_H but it apparently does
not need -lcharset. It could be that the port is incomplete, but another
possibility is that perhaps the function is in part of libc and does not
even need -lcharset passed to the linker.

If you look at our Makefile, you see "On this platform foo() can be
obtained by linking with -lfoo, but on this other platform you need to
link with -lbar" gotchas around some libraries (e.g. ssl/crypto), and I am
wondering if this function has a similar issue.

  reply	other threads:[~2012-02-10 18:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-10  1:29 1.7.9, libcharset missing from EXTLIBS Дилян Палаузов
2012-02-10  2:13 ` Junio C Hamano
2012-02-10 10:06   ` Ævar Arnfjörð Bjarmason
2012-02-10 10:21     ` Дилян Палаузов
2012-02-10 18:35       ` Junio C Hamano [this message]
2012-02-10 19:52         ` Dilyan Palauzov
2012-02-10 20:10           ` Erik Faye-Lund
2012-02-10 20:25         ` Junio C Hamano
2012-02-12  0:55           ` Дилян Палаузов
2012-02-12  1:03             ` Ævar Arnfjörð Bjarmason
2012-02-12 10:30             ` Junio C Hamano
2012-02-12 16:23               ` [PATCH] " Дилян Палаузов
2012-02-10 13:15     ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vipjer0yn.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox$(echo .)com \
    --cc=avarab@gmail$(echo .)com \
    --cc=dilyan.palauzov@aegee$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox