* [PATCH] Fix off-by-one in read_tree_recursive [not found] <cover.1240249482u.git.johannes.schindelin@gmx.de> @ 2009-04-20 17:44 ` Johannes Schindelin 2009-04-20 18:06 ` valgrind Andy Lester 2009-04-21 5:33 ` [PATCH] Fix off-by-one in read_tree_recursive Junio C Hamano 0 siblings, 2 replies; 5+ messages in thread From: Johannes Schindelin @ 2009-04-20 17:44 UTC (permalink / raw) To: git, gitster Found by valgrind. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx•de> --- tree.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tree.c b/tree.c index 0d703a0..5ab90af 100644 --- a/tree.c +++ b/tree.c @@ -62,6 +62,7 @@ static int match_tree_entry(const char *base, int baselen, const char *path, uns continue; /* pathspecs match only at the directory boundaries */ if (!matchlen || + baselen == matchlen || base[matchlen] == '/' || match[matchlen - 1] == '/') return 1; -- 1.6.2.1.493.g67cf3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* valgrind 2009-04-20 17:44 ` [PATCH] Fix off-by-one in read_tree_recursive Johannes Schindelin @ 2009-04-20 18:06 ` Andy Lester 2009-04-20 18:34 ` valgrind Johannes Schindelin 2009-04-21 5:33 ` [PATCH] Fix off-by-one in read_tree_recursive Junio C Hamano 1 sibling, 1 reply; 5+ messages in thread From: Andy Lester @ 2009-04-20 18:06 UTC (permalink / raw) To: Johannes Schindelin; +Cc: git, gitster On Apr 20, 2009, at 12:44 PM, Johannes Schindelin wrote: > Found by valgrind. How are you running valgrind? Do you have a test suite for it? A make target? xoa -- Andy Lester => andy@petdance•com => www.theworkinggeek.com => AIM:petdance ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: valgrind 2009-04-20 18:06 ` valgrind Andy Lester @ 2009-04-20 18:34 ` Johannes Schindelin 2009-04-20 18:36 ` valgrind Andy Lester 0 siblings, 1 reply; 5+ messages in thread From: Johannes Schindelin @ 2009-04-20 18:34 UTC (permalink / raw) To: Andy Lester; +Cc: git, gitster Hi, On Mon, 20 Apr 2009, Andy Lester wrote: > On Apr 20, 2009, at 12:44 PM, Johannes Schindelin wrote: > > >Found by valgrind. > > How are you running valgrind? Do you have a test suite for it? A make > target? Yes, it was merged into Git: http://repo.or.cz/w/alt-git.git?a=commitdiff;h=8a61097cde387870921e822bdf90b4ffd3792845 Hth, Dscho ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: valgrind 2009-04-20 18:34 ` valgrind Johannes Schindelin @ 2009-04-20 18:36 ` Andy Lester 0 siblings, 0 replies; 5+ messages in thread From: Andy Lester @ 2009-04-20 18:36 UTC (permalink / raw) To: Johannes Schindelin; +Cc: git, gitster On Apr 20, 2009, at 1:34 PM, Johannes Schindelin wrote: > Yes, it was merged into Git: > > http://repo.or.cz/w/alt-git.git?a=commitdiff;h=8a61097cde387870921e822bdf90b4ffd3792845 Very cool. In my Copious Free Time, I'm trying to get a splint target built up. xoxo, Andy -- Andy Lester => andy@petdance•com => www.theworkinggeek.com => AIM:petdance ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix off-by-one in read_tree_recursive 2009-04-20 17:44 ` [PATCH] Fix off-by-one in read_tree_recursive Johannes Schindelin 2009-04-20 18:06 ` valgrind Andy Lester @ 2009-04-21 5:33 ` Junio C Hamano 1 sibling, 0 replies; 5+ messages in thread From: Junio C Hamano @ 2009-04-21 5:33 UTC (permalink / raw) To: Johannes Schindelin; +Cc: git, gitster Thanks. . ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-04-21 5:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1240249482u.git.johannes.schindelin@gmx.de>
2009-04-20 17:44 ` [PATCH] Fix off-by-one in read_tree_recursive Johannes Schindelin
2009-04-20 18:06 ` valgrind Andy Lester
2009-04-20 18:34 ` valgrind Johannes Schindelin
2009-04-20 18:36 ` valgrind Andy Lester
2009-04-21 5:33 ` [PATCH] Fix off-by-one in read_tree_recursive Junio C Hamano
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox