From: Junio C Hamano <gitster@pobox•com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail•com>
Cc: git@vger•kernel.org, "Sebastian Pipping" <webmaster@hartwork•org>,
"SZEDER Gábor" <szeder@ira•uka.de>,
"Matthieu Moy" <Matthieu.Moy@grenoble-inp•fr>,
"Jeff King" <peff@peff•net>
Subject: Re: [PATCH 1.8.0] add: make "add -u" update full tree without pathspec
Date: Sun, 27 Feb 2011 11:39:52 -0800 [thread overview]
Message-ID: <7vy6512rnb.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <AANLkTi=BwTHRWcUu26VLWAhFupmuJpu8fvOF98--HJ5f@mail.gmail.com> (Nguyen Thai Ngoc Duy's message of "Sun\, 27 Feb 2011 23\:52\:34 +0700")
Nguyen Thai Ngoc Duy <pclouds@gmail•com> writes:
> On Sun, Feb 27, 2011 at 5:46 PM, Junio C Hamano <gitster@pobox•com> wrote:
>> Perhaps in this order:
>>
>> Step 1, as soon as possible:
>>
>> * Introduce "add.make_update_global" configuration variable, and toggle
>> the above variable when it is explicitly given; also record the fact
>> that you actually saw this variable in the config parser regardless of
>> the value that is given;
>
> Ermm.. compat.make_update_global, with the intent that the config will
> be dropped in future (1.9.0 maybe)?
As you haven't yet proven that this "new feature" is even useful to help
new people nor existing users at this step, you cannot claim "we plan to
drop this in the future", hence naming it "compat.*" is a no-go. During
this step, we can not even say "we plan to make this the default"; we
would confuse the users otherwise (it is fine to say "we might make this
the default some day").
Even if we indeed end up proceeding to step 2, I don't see a point in
planning to drop the support from the beginning. We might end up doing
so, but we can decide when that becomes necessary, and that would be long
after the tree-wide default proves a reasonable one, and preferably after
seeing a new person or two raise "what's the point of making 'add -u'
restricted to cwd? we have too many options and this can go" on the list.
Then we would start deprecating the config, giving a warning when people
who still rely on their "add.make_update_global = false" say "add -u"
without pathspec in a few cycles, and then finally drop it at a version
bump boundary.
> There's a problem. I use git on many machines. Some will have this
> config enabled, some will not (yet). Perhaps a third option, which
> will print something when "git add -u" is issued as a reminder?
Such a warning would not help you on a machine that does not even have git
with Step 1 change.
What you conceive as a problem is just a reminder that any incompatible
change you plan to add will have pain involved. On two machines, one with
a new feature and the other without the new feature, you would have to
work differently _or_ you would train yourself to use both versions in a
compatible way (e.g. when you mean tree-wide, you would cdup, and when you
mean cwd, you would explicitly say ".", from the command line). That is
not limited to this particular feature but any incompatible change, no?
next prev parent reply other threads:[~2011-02-27 19:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 2:27 [PATCH 1.8.0] add: make "add -u" update full tree without pathspec Nguyễn Thái Ngọc Duy
2011-02-07 5:58 ` Junio C Hamano
2011-02-07 6:14 ` Nguyen Thai Ngoc Duy
2011-02-07 6:26 ` Miles Bader
2011-02-09 10:58 ` Joshua Juran
2011-02-07 12:09 ` Matthieu Moy
2011-02-27 10:46 ` Junio C Hamano
2011-02-27 11:43 ` Matthieu Moy
2011-02-27 17:04 ` Nguyen Thai Ngoc Duy
2011-02-27 13:35 ` Sverre Rabbelier
2011-02-27 17:01 ` Nguyen Thai Ngoc Duy
2011-02-27 16:52 ` Nguyen Thai Ngoc Duy
2011-02-27 19:39 ` Junio C Hamano [this message]
2011-02-28 6:37 ` Nguyen Thai Ngoc Duy
2011-02-28 6:56 ` Junio C Hamano
2011-03-01 11:22 ` Nguyen Thai Ngoc Duy
2011-03-01 13:46 ` Junio C Hamano
2011-03-01 14:15 ` Nguyen Thai Ngoc Duy
2011-03-01 14:53 ` Matthieu Moy
2011-03-01 18:40 ` Junio C Hamano
2011-03-01 18:51 ` Matthieu Moy
2011-03-01 19:36 ` Jakub Narebski
2011-03-01 20:00 ` Jeff King
2011-03-01 20:12 ` Junio C Hamano
2011-03-01 20:25 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy6512rnb.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=szeder@ira$(echo .)uka.de \
--cc=webmaster@hartwork$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox