public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg•org>
To: Wang Zichong <wangzichong@deepin•org>
Cc: git@blumia•net, git@vger•kernel.org, gitgitgadget@gmail•com,
	gitster@pobox•com
Subject: Re: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences
Date: Sat, 28 Feb 2026 08:51:01 +0100	[thread overview]
Message-ID: <8526ae9b-804b-4f39-b5bd-1a8971cc7d6c@kdbg.org> (raw)
In-Reply-To: <3FA6BA9ACF1B34AF+20260228033725.2546976-1-wangzichong@deepin.org>

Am 28.02.26 um 04:37 schrieb Wang Zichong:
> This usage is actually from the example provided at GitGitGadget's
> landing page:
> 
>     https://gitgitgadget.github.io/
> 
> If writing multiple CC trailers is preferred, maybe we also need to update
> GitGitGadget's documentation as well.
This page says:

"You can CC potential reviewers by adding a footer to the PR description..."

The commit message is not the PR description. Please don't add Cc lines
to the commit message. Edit the PR description on Github before you
/submit the patches with GitGitGadget.

-- Hannes


  reply	other threads:[~2026-02-28  7:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 12:33 [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences Gary Wang via GitGitGadget
2026-02-26 15:25 ` Junio C Hamano
2026-02-27  7:37 ` Johannes Sixt
2026-02-27 16:49   ` Junio C Hamano
2026-02-28  3:37     ` Wang Zichong
2026-02-28  7:51       ` Johannes Sixt [this message]
2026-02-28  8:02         ` Wang Zichong
2026-02-28  4:05 ` [PATCH v2] gitk: support link color in the Preferences dialog Gary Wang via GitGitGadget
2026-02-28  7:59   ` [PATCH v3] " Gary Wang via GitGitGadget
2026-03-01 10:30     ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8526ae9b-804b-4f39-b5bd-1a8971cc7d6c@kdbg.org \
    --to=j6t@kdbg$(echo .)org \
    --cc=git@blumia$(echo .)net \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitgitgadget@gmail$(echo .)com \
    --cc=gitster@pobox$(echo .)com \
    --cc=wangzichong@deepin$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox