From: Johannes Sixt <j6t@kdbg•org>
To: Wang Zichong <wangzichong@deepin•org>
Cc: Gary Wang <git@blumia•net>,
git@vger•kernel.org,
Gary Wang via GitGitGadget <gitgitgadget@gmail•com>,
Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences
Date: Fri, 27 Feb 2026 08:37:20 +0100 [thread overview]
Message-ID: <ffd58cd5-811b-4ebf-8572-cca681ec9bf7@kdbg.org> (raw)
In-Reply-To: <pull.2217.git.git.1772109195114.gitgitgadget@gmail.com>
Am 26.02.26 um 13:33 schrieb Gary Wang via GitGitGadget:
> From: Wang Zichong <wangzichong@deepin•org>
>
> As a dark-theme user, I use the Preferences dialog to set colors
> for gitk, the only color I cannot change via that dialog is the
> link foreground color, which will lead me to use the default link
> color on a dark background that make it not really readable.
>
> This patch makes the link foreground color also configurable in the
> Gitk Preferences dialog's Color tab, so user won't need to dig into
> the code/manual to know if the link color is configurable and can
> simply set the color there.
Makes sense.
Our usual style is to not say "This patch does X to...", but to write in
imperative mood "Do X to...".
>
> CC: Mark Levedahl <mlevedahl@gmail•com>, Paul Mackerras <paulus@samba•org>
> Signed-off-by: Wang Zichong <wangzichong@deepin•org>
> ---
> gitk: support config the color of linkfgcolor via Gitk Preferences
In the subject line, perhaps:
gitk: support link color in the Preferences dialog
> + label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor
> + ttk::button $page.linkfgbut -text [mc "Link color"] \
> + -command [list choosecolor linkfgcolor {} $page [mc "link color"]]
This text "link color" is used in the title of the color selection
dialog. It then reads awkwardly "Gitk: choose color for link color".
Let's just use the text "links" for this purpose, and then also just
"Links" as the label on the button.
> @@ -11891,6 +11896,7 @@ proc prefspage_set_colorswatches {page} {
> $page.hunksep configure -background [lindex $diffcolors 2]
> $page.markbgsep configure -background $markbgcolor
> $page.selbgsep configure -background $selectbgcolor
> + $page.linkfg configure -background $linkfgcolor
The variable's value is already serialized in the configuration and
needs no additional treatment. Good.
-- Hannes
next prev parent reply other threads:[~2026-02-27 8:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 12:33 [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences Gary Wang via GitGitGadget
2026-02-26 15:25 ` Junio C Hamano
2026-02-27 7:37 ` Johannes Sixt [this message]
2026-02-27 16:49 ` Junio C Hamano
2026-02-28 3:37 ` Wang Zichong
2026-02-28 7:51 ` Johannes Sixt
2026-02-28 8:02 ` Wang Zichong
2026-02-28 4:05 ` [PATCH v2] gitk: support link color in the Preferences dialog Gary Wang via GitGitGadget
2026-02-28 7:59 ` [PATCH v3] " Gary Wang via GitGitGadget
2026-03-01 10:30 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffd58cd5-811b-4ebf-8572-cca681ec9bf7@kdbg.org \
--to=j6t@kdbg$(echo .)org \
--cc=git@blumia$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=gitster@pobox$(echo .)com \
--cc=wangzichong@deepin$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox