* Anonymous commit (empty Author and Committer)
@ 2015-10-30 14:26 Andrei Borzenkov
2015-10-30 14:33 ` Konstantin Khomoutov
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Andrei Borzenkov @ 2015-10-30 14:26 UTC (permalink / raw)
To: The development of GRUB 2; +Cc: git, savannah-users
See
http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac
I was not even aware that this is possible. Is there anything on server
side that can prevent it?
Would be good if commit were amended and force pushed to fix it.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Anonymous commit (empty Author and Committer)
2015-10-30 14:26 Andrei Borzenkov
@ 2015-10-30 14:33 ` Konstantin Khomoutov
2015-10-30 17:01 ` Jeff King
[not found] ` <5633CDCD.10004@gmail.com>
2 siblings, 0 replies; 14+ messages in thread
From: Konstantin Khomoutov @ 2015-10-30 14:33 UTC (permalink / raw)
To: Andrei Borzenkov; +Cc: The development of GRUB 2, git, savannah-users
On Fri, 30 Oct 2015 17:26:00 +0300
Andrei Borzenkov <arvidjaar@gmail•com> wrote:
> See
> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac
>
> I was not even aware that this is possible. Is there anything on
> server side that can prevent it?
A hook running on "update" event could check the commits being pushed
and reject the update if some commit among those does not pass the
necessary checks.
Please see the githooks(5) manual page.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Anonymous commit (empty Author and Committer)
2015-10-30 14:26 Andrei Borzenkov
2015-10-30 14:33 ` Konstantin Khomoutov
@ 2015-10-30 17:01 ` Jeff King
[not found] ` <5633CDCD.10004@gmail.com>
2 siblings, 0 replies; 14+ messages in thread
From: Jeff King @ 2015-10-30 17:01 UTC (permalink / raw)
To: Andrei Borzenkov; +Cc: The development of GRUB 2, git, savannah-users
On Fri, Oct 30, 2015 at 05:26:00PM +0300, Andrei Borzenkov wrote:
> See http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac
>
> I was not even aware that this is possible. Is there anything on server side
> that can prevent it?
I would have thought that receive.fsckObjects would reject it, but seems
that git-fsck does not complain about it at all, as it is otherwise
syntactically valid (a space separating the zero-length name from the
email, and <> surrounding the empty email).
We do complain during "git commit" about an empty name. We don't seem to
do so for blank emails, though. The only discussion I could find
mentions that should probably disallow both[1].
I wonder how this commit was created in the first place (through
git-commit, and we have an empty-name case that is not covered, or using
a lower-level tool that bypasses the checks).
-Peff
[1] http://article.gmane.org/gmane.comp.version-control.git/261237
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Anonymous commit (empty Author and Committer)
[not found] ` <5633CDCD.10004@gmail.com>
@ 2015-10-30 20:09 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-10-30 20:19 ` Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 1 reply; 14+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2015-10-30 20:09 UTC (permalink / raw)
To: The development of GNU GRUB, git, savannah-users
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 30.10.2015 15:26, Andrei Borzenkov wrote:
>> See
>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac
>>
>>
>> I was not even aware that this is possible. Is there anything on server
>> side that can prevent it?
>>
>> Would be good if commit were amended and force pushed to fix it.
>>
> It is a bug in SGit. I'll investigate how it happened
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu•org
>> https://lists.gnu.org/mailman/listinfo/grub-devel
>> .
>>
>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Anonymous commit (empty Author and Committer)
2015-10-30 20:09 ` Vladimir 'φ-coder/phcoder' Serbinenko
@ 2015-10-30 20:19 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-10-30 20:59 ` Lennart Sorensen
2015-10-31 13:54 ` Andrei Borzenkov
0 siblings, 2 replies; 14+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2015-10-30 20:19 UTC (permalink / raw)
To: The development of GNU GRUB, git, savannah-users
[-- Attachment #1.1: Type: text/plain, Size: 675 bytes --]
On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> On 30.10.2015 15:26, Andrei Borzenkov wrote:
>>> See
>>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac
>>>
>>>
>>> I was not even aware that this is possible. Is there anything on server
>>> side that can prevent it?
>>>
>>> Would be good if commit were amended and force pushed to fix it.
>>>
>> It is a bug in SGit. I'll investigate how it happened
I don't have non-fast-forward rights. Does someone from savannah-users
have them? Could he just delete this commit?
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
[-- Attachment #2: Type: text/plain, Size: 141 bytes --]
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu•org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Anonymous commit (empty Author and Committer)
2015-10-30 20:19 ` Vladimir 'φ-coder/phcoder' Serbinenko
@ 2015-10-30 20:59 ` Lennart Sorensen
2015-10-30 21:45 ` Kaz Kylheku
2015-10-31 5:24 ` Andrei Borzenkov
2015-10-31 13:54 ` Andrei Borzenkov
1 sibling, 2 replies; 14+ messages in thread
From: Lennart Sorensen @ 2015-10-30 20:59 UTC (permalink / raw)
To: The development of GNU GRUB; +Cc: savannah-users, git
On Fri, Oct 30, 2015 at 09:19:19PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> > On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> >> On 30.10.2015 15:26, Andrei Borzenkov wrote:
> >>> See
> >>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac
> >>>
> >>>
> >>> I was not even aware that this is possible. Is there anything on server
> >>> side that can prevent it?
> >>>
> >>> Would be good if commit were amended and force pushed to fix it.
> >>>
> >> It is a bug in SGit. I'll investigate how it happened
>
> I don't have non-fast-forward rights. Does someone from savannah-users
> have them? Could he just delete this commit?
If you do that, then anyone that already did a pull after it went in
will have a broken tree. Rather annoying.
--
Len Sorensen
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu•org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Anonymous commit (empty Author and Committer)
2015-10-30 20:59 ` Lennart Sorensen
@ 2015-10-30 21:45 ` Kaz Kylheku
2015-10-31 7:02 ` Andreas Schwab
2015-10-31 5:24 ` Andrei Borzenkov
1 sibling, 1 reply; 14+ messages in thread
From: Kaz Kylheku @ 2015-10-30 21:45 UTC (permalink / raw)
To: Lennart Sorensen
Cc: The development of GNU GRUB,
savannah-users-bounces+kaz=kylheku.com, git, savannah-users
On 30.10.2015 13:59, Lennart Sorensen wrote:
>> I don't have non-fast-forward rights. Does someone from savannah-users
>> have them? Could he just delete this commit?
>
> If you do that, then anyone that already did a pull after it went in
> will have a broken tree. Rather annoying.
Nope. They will have a git in which that commit looks like their own
local work. *Someone* will inadvertently do a "git push" to blast out
their changes based on that deleted commit, thereby causing it to
reappear.
:)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Anonymous commit (empty Author and Committer)
2015-10-30 20:59 ` Lennart Sorensen
2015-10-30 21:45 ` Kaz Kylheku
@ 2015-10-31 5:24 ` Andrei Borzenkov
2015-11-02 15:11 ` Lennart Sorensen
1 sibling, 1 reply; 14+ messages in thread
From: Andrei Borzenkov @ 2015-10-31 5:24 UTC (permalink / raw)
To: The development of GNU GRUB; +Cc: savannah-users, git
30.10.2015 23:59, Lennart Sorensen пишет:
> On Fri, Oct 30, 2015 at 09:19:19PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>> On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>>> On 30.10.2015 15:26, Andrei Borzenkov wrote:
>>>>> See
>>>>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac
>>>>>
>>>>>
>>>>> I was not even aware that this is possible. Is there anything on server
>>>>> side that can prevent it?
>>>>>
>>>>> Would be good if commit were amended and force pushed to fix it.
>>>>>
>>>> It is a bug in SGit. I'll investigate how it happened
>>
>> I don't have non-fast-forward rights. Does someone from savannah-users
>> have them? Could he just delete this commit?
>
> If you do that, then anyone that already did a pull after it went in
> will have a broken tree. Rather annoying.
>
If we decide to fix this commit it is better done now, while it is the
last one. It is annoying but do you have suggestion how it can be done
differently?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Anonymous commit (empty Author and Committer)
2015-10-30 21:45 ` Kaz Kylheku
@ 2015-10-31 7:02 ` Andreas Schwab
2015-10-31 13:46 ` Andrei Borzenkov
0 siblings, 1 reply; 14+ messages in thread
From: Andreas Schwab @ 2015-10-31 7:02 UTC (permalink / raw)
To: Kaz Kylheku
Cc: The development of GNU GRUB, savannah-users,
savannah-users-bounces+kaz=kylheku.com, git, Lennart Sorensen
Kaz Kylheku <kaz@kylheku•com> writes:
> Nope. They will have a git in which that commit looks like their own
> local work. *Someone* will inadvertently do a "git push" to blast out
> their changes based on that deleted commit, thereby causing it to
> reappear.
Not if another one pushes something different in the mean time.
Andreas.
--
Andreas Schwab, schwab@linux-m68k•org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Anonymous commit (empty Author and Committer)
@ 2015-10-31 12:12 André Z. D. A.
0 siblings, 0 replies; 14+ messages in thread
From: André Z. D. A. @ 2015-10-31 12:12 UTC (permalink / raw)
To: savannah-users, git, The development of GNU GRUB
> 30.10.2015 23:59, Lennart Sorensen пишет:
>
>> On Fri, Oct 30, 2015 at 09:19:19PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>
>>> On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>>
>>>> On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>>>
>>>>> On 30.10.2015 15:26, Andrei Borzenkov wrote:
>>>>>
>>>>>> See
>>>>>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac
>>>>>>
>>>>>> I was not even aware that this is possible. Is there anything on server
>>>>>> side that can prevent it?
>>>>>>
>>>>>> Would be good if commit were amended and force pushed to fix it.
>>>>>
>>>>> It is a bug in SGit. I'll investigate how it happened
>>>
>>> I don't have non-fast-forward rights. Does someone from savannah-users
>>> have them? Could he just delete this commit?
>>
>> If you do that, then anyone that already did a pull after it went in
>> will have a broken tree. Rather annoying.
>
> If we decide to fix this commit it is better done now, while it is the
> last one. It is annoying but do you have suggestion how it can be done
> differently?
+1 to undo it now
Indeed. The faster it is fixed smaller the number of potential unintentional repeats for it, if any.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Anonymous commit (empty Author and Committer)
2015-10-31 7:02 ` Andreas Schwab
@ 2015-10-31 13:46 ` Andrei Borzenkov
0 siblings, 0 replies; 14+ messages in thread
From: Andrei Borzenkov @ 2015-10-31 13:46 UTC (permalink / raw)
To: The development of GNU GRUB, Kaz Kylheku
Cc: savannah-users, savannah-users-bounces+kaz=kylheku.com, git,
Lennart Sorensen
31.10.2015 10:02, Andreas Schwab пишет:
> Kaz Kylheku <kaz@kylheku•com> writes:
>
>> Nope. They will have a git in which that commit looks like their own
>> local work. *Someone* will inadvertently do a "git push" to blast out
>> their changes based on that deleted commit, thereby causing it to
>> reappear.
>
> Not if another one pushes something different in the mean time.
>
Which is why I said "amended".
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Anonymous commit (empty Author and Committer)
2015-10-30 20:19 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-10-30 20:59 ` Lennart Sorensen
@ 2015-10-31 13:54 ` Andrei Borzenkov
1 sibling, 0 replies; 14+ messages in thread
From: Andrei Borzenkov @ 2015-10-31 13:54 UTC (permalink / raw)
To: The development of GNU GRUB, git, savannah-users
30.10.2015 23:19, Vladimir 'φ-coder/phcoder' Serbinenko пишет:
> On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>> On 30.10.2015 15:26, Andrei Borzenkov wrote:
>>>> See
>>>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac
>>>>
>>>>
>>>> I was not even aware that this is possible. Is there anything on server
>>>> side that can prevent it?
>>>>
>>>> Would be good if commit were amended and force pushed to fix it.
>>>>
>>> It is a bug in SGit. I'll investigate how it happened
>
> I don't have non-fast-forward rights. Does someone from savannah-users
> have them? Could he just delete this commit?
Looking at mail archives, non-fast-forward is global repository property
and disabled by default. We probably need to open Savannah ticket to get
it temporary enabled.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Anonymous commit (empty Author and Committer)
2015-10-31 5:24 ` Andrei Borzenkov
@ 2015-11-02 15:11 ` Lennart Sorensen
2015-11-02 16:42 ` Junio C Hamano
0 siblings, 1 reply; 14+ messages in thread
From: Lennart Sorensen @ 2015-11-02 15:11 UTC (permalink / raw)
To: The development of GNU GRUB; +Cc: savannah-users, git
On Sat, Oct 31, 2015 at 08:24:06AM +0300, Andrei Borzenkov wrote:
> If we decide to fix this commit it is better done now, while it is the last
> one. It is annoying but do you have suggestion how it can be done
> differently?
Well the only options are:
1) Leave it alone
2) Break the tree of anyone that already pulled. (Posting instructions on
how to fix it would at least be nice then).
Not sure how many people regularly pull the tree.
--
Len Sorensen
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Anonymous commit (empty Author and Committer)
2015-11-02 15:11 ` Lennart Sorensen
@ 2015-11-02 16:42 ` Junio C Hamano
0 siblings, 0 replies; 14+ messages in thread
From: Junio C Hamano @ 2015-11-02 16:42 UTC (permalink / raw)
To: Lennart Sorensen; +Cc: The development of GNU GRUB, savannah-users, git
"Lennart Sorensen" <lsorense@csclub•uwaterloo.ca> writes:
> On Sat, Oct 31, 2015 at 08:24:06AM +0300, Andrei Borzenkov wrote:
>> If we decide to fix this commit it is better done now, while it is the last
>> one. It is annoying but do you have suggestion how it can be done
>> differently?
>
> Well the only options are:
>
> 1) Leave it alone
> 2) Break the tree of anyone that already pulled. (Posting instructions on
> how to fix it would at least be nice then).
>
> Not sure how many people regularly pull the tree.
Is the discussion still require attention by Git folks for their
help? If not, could you take this back to savannah specific mailing
list?
Thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2015-11-02 16:42 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-31 12:12 Anonymous commit (empty Author and Committer) André Z. D. A.
-- strict thread matches above, loose matches on Subject: below --
2015-10-30 14:26 Andrei Borzenkov
2015-10-30 14:33 ` Konstantin Khomoutov
2015-10-30 17:01 ` Jeff King
[not found] ` <5633CDCD.10004@gmail.com>
2015-10-30 20:09 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-10-30 20:19 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-10-30 20:59 ` Lennart Sorensen
2015-10-30 21:45 ` Kaz Kylheku
2015-10-31 7:02 ` Andreas Schwab
2015-10-31 13:46 ` Andrei Borzenkov
2015-10-31 5:24 ` Andrei Borzenkov
2015-11-02 15:11 ` Lennart Sorensen
2015-11-02 16:42 ` Junio C Hamano
2015-10-31 13:54 ` Andrei Borzenkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox