From: Kjetil Barvik <barvik@broadpark•no>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH] Cleanup of unused symcache variable inside diff-lib.c
Date: Sun, 11 Jan 2009 21:50:29 +0100 [thread overview]
Message-ID: <86ab9x8t4a.fsf@broadpark.no> (raw)
In-Reply-To: <alpine.DEB.1.00.0901112112540.3586@pacific.mpi-cbg.de>
Johannes Schindelin <Johannes.Schindelin@gmx•de> writes:
<snipp>
>> --signoff
>
> If you had signed off on your commits already, not necessary. (FWIW I
> keep a sign off as a marker that I actually think this is good to be
> submitted, or at least close.)
From the Documentation/SubmittingPatches file, for me I think that the
'-signoff' is supposed to mean:
[....]
- if you want your work included in git.git, add a "Signed-off-by:
Your Name <you@example•com>" line to the commit message (or just
use the option "-s" when committing) to confirm that you agree to
the Developer's Certificate of Origin
[....]
The sign-off is a simple line at the end of the explanation for the
patch, which certifies that you wrote it or otherwise have the right
to pass it on as a open-source patch. The rules are pretty simple: if
you can certify the below:
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
[....]
then you just add a line saying
Signed-off-by: Random J Developer <random@developer•example.org>
This line can be automatically added by git if you run the git-commit
command with the -s option.
[....]
And the 'a' and the 'd' in the DCO I do agree with in this particular
situation, so I added a '--signoff' to the patches.
-- kjetil
next prev parent reply other threads:[~2009-01-11 20:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 18:36 [PATCH] Cleanup of unused symcache variable inside diff-lib.c Kjetil Barvik
2009-01-11 18:45 ` Johannes Schindelin
2009-01-11 19:32 ` Kjetil Barvik
2009-01-11 19:46 ` Johannes Schindelin
2009-01-11 20:09 ` Kjetil Barvik
2009-01-11 20:17 ` Johannes Schindelin
2009-01-11 20:50 ` Kjetil Barvik [this message]
2009-01-11 22:25 ` Junio C Hamano
2009-01-11 22:23 ` Junio C Hamano
2009-01-12 5:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ab9x8t4a.fsf@broadpark.no \
--to=barvik@broadpark$(echo .)no \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox