From: merlyn@stonehenge•com (Randal L. Schwartz)
To: Junio C Hamano <junkio@cox•net>
Cc: Jakub Narebski <jnareb@gmail•com>, git@vger•kernel.org
Subject: Re: [RFD] gitweb: href() function to generate URLs for CGI
Date: 22 Aug 2006 11:35:12 -0700 [thread overview]
Message-ID: <86fyfohb4v.fsf@blue.stonehenge.com> (raw)
In-Reply-To: <7vodudno88.fsf@assigned-by-dhcp.cox.net>
>>>>> "Junio" == Junio C Hamano <junkio@cox•net> writes:
Junio> my @result = ();
Junio> for (my $i = 0; $i < @mapping; $i += 2) {
Junio> my ($name, $symbol) = ($mapping[$i], $mapping[$i+1]);
Junio> if (defined $params{$name}) {
Junio> push @result, "$symbol=$params{$name}";
Junio> }
Junio> }
Junio> return "$my_uri?" . esc_param(join(';', @result));
Junio> }
If you already depend on the LWP package, then the "URI" module
does precisely what you're reinventing.
my $uri = URI->new("http://host/base/path")
$uri->query_form(\%params);
my $result = $uri->as_string;
And I'd rely on Gisle Aas's experience about constructing these things
far more than the thread I've just witnessed here. :)
--
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge•com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!
next prev parent reply other threads:[~2006-08-22 18:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-21 15:39 [RFD] gitweb: href() function to generate URLs for CGI Jakub Narebski
2006-08-21 15:52 ` Jakub Narebski
2006-08-21 18:22 ` Junio C Hamano
2006-08-21 18:38 ` Jakub Narebski
2006-08-22 7:09 ` Junio C Hamano
2006-08-22 8:18 ` Jakub Narebski
2006-08-22 8:55 ` Junio C Hamano
2006-08-22 9:34 ` Jakub Narebski
2006-08-22 10:47 ` Jakub Narebski
2006-08-22 22:26 ` Junio C Hamano
2006-08-22 22:39 ` Jakub Narebski
2006-08-22 18:35 ` Randal L. Schwartz [this message]
2006-08-22 19:55 ` Jakub Narebski
2006-08-22 20:01 ` Jakub Narebski
2006-08-22 22:21 ` Junio C Hamano
2006-08-22 17:05 ` [PATCH 1/2] gitweb: Drop the href() params which keys are not in %mapping Jakub Narebski
2006-08-22 17:05 ` [PATCH 2/2] gitweb: Sort CGI parameters returned by href() Jakub Narebski
-- strict thread matches above, loose matches on Subject: below --
2006-08-21 15:21 [RFD] gitweb: href() function to generate URLs for CGI Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fyfohb4v.fsf@blue.stonehenge.com \
--to=merlyn@stonehenge$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jnareb@gmail$(echo .)com \
--cc=junkio@cox$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox