From: Jakub Narebski <jnareb@gmail•com>
To: git@vger•kernel.org
Subject: Re: [RFD] gitweb: href() function to generate URLs for CGI
Date: Tue, 22 Aug 2006 22:01:25 +0200 [thread overview]
Message-ID: <ecfnqj$5m9$1@sea.gmane.org> (raw)
In-Reply-To: ecfnf0$4bg$1@sea.gmane.org
<opublikowany i wysłany>
Jakub Narebski wrote:
> Randal L. Schwartz wrote:
>
>>>>>>> "Junio" == Junio C Hamano <junkio@cox•net> writes:
>>
>> Junio> my @result = ();
>> Junio> for (my $i = 0; $i < @mapping; $i += 2) {
>> Junio> my ($name, $symbol) = ($mapping[$i], $mapping[$i+1]);
>> Junio> if (defined $params{$name}) {
>> Junio> push @result, "$symbol=$params{$name}";
>> Junio> }
>> Junio> }
>> Junio> return "$my_uri?" . esc_param(join(';', @result));
>> Junio> }
>>
>> If you already depend on the LWP package, then the "URI" module
>> does precisely what you're reinventing.
>>
>> my $uri = URI->new("http://host/base/path")
>> $uri->query_form(\%params);
>> my $result = $uri->as_string;
>>
>> And I'd rely on Gisle Aas's experience about constructing these things
>> far more than the thread I've just witnessed here. :)
>
> First, I'd rather not introduce new dependency to git (and I think Junio
> would agree). Second, more important, we do _parameters processing_,
> it means renaming parameters (e.g. 'file_name' in params is 'p' in CGI URI),
> in the future perhaps passing project via PATH_INFO not in query string,
> and sorting the CGI parameters.
>
> So it wouldn't be as easy as writing
> $uri->query_form(\%params);
> return $uri->as_string;
> or as
> return "$my_uri?" . esc_param(join(";", "$_=$params{$_}") keys %params)'.
Third, read comment to esc_param:
# quote unsafe chars, but keep the slash, even when it's not
# correct, but quoted slashes look too horrible in bookmarks
I assume that URI module methods do not keep slash...
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-08-22 20:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-21 15:39 [RFD] gitweb: href() function to generate URLs for CGI Jakub Narebski
2006-08-21 15:52 ` Jakub Narebski
2006-08-21 18:22 ` Junio C Hamano
2006-08-21 18:38 ` Jakub Narebski
2006-08-22 7:09 ` Junio C Hamano
2006-08-22 8:18 ` Jakub Narebski
2006-08-22 8:55 ` Junio C Hamano
2006-08-22 9:34 ` Jakub Narebski
2006-08-22 10:47 ` Jakub Narebski
2006-08-22 22:26 ` Junio C Hamano
2006-08-22 22:39 ` Jakub Narebski
2006-08-22 18:35 ` Randal L. Schwartz
2006-08-22 19:55 ` Jakub Narebski
2006-08-22 20:01 ` Jakub Narebski [this message]
2006-08-22 22:21 ` Junio C Hamano
2006-08-22 17:05 ` [PATCH 1/2] gitweb: Drop the href() params which keys are not in %mapping Jakub Narebski
2006-08-22 17:05 ` [PATCH 2/2] gitweb: Sort CGI parameters returned by href() Jakub Narebski
-- strict thread matches above, loose matches on Subject: below --
2006-08-21 15:21 [RFD] gitweb: href() function to generate URLs for CGI Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ecfnqj$5m9$1@sea.gmane.org' \
--to=jnareb@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox