From: Ted Zlatanov <tzz@lifelogs•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] git-credential-netrc: fix uninitialized warning
Date: Tue, 08 Oct 2013 16:12:56 -0400 [thread overview]
Message-ID: <8761t7v7w7.fsf@flea.lifelogs.com> (raw)
In-Reply-To: <20131008200235.GG9464@google.com> (Jonathan Nieder's message of "Tue, 8 Oct 2013 13:02:35 -0700")
On Tue, 8 Oct 2013 13:02:35 -0700 Jonathan Nieder <jrnieder@gmail•com> wrote:
JN> Ted Zlatanov wrote:
>> On Tue, 8 Oct 2013 12:41:47 -0700 Jonathan Nieder <jrnieder@gmail•com> wrote:
JN> Ted Zlatanov wrote:
>>>> Simple patch to avoid unitialized warning and log what we'll do.
JN> Sign-off?
>>
>> I didn't realize it was a requirement, must I?
JN> See Documentation/SubmittingPatches, section '(5) Sign your work'
JN> for what this means.
JN> If you just forgot to sign off, that's fine and I can forge it or go
JN> without. If you are unable to sign off because you don't have the
JN> right to submit the change under an open source license, I'd be a bit
JN> worried going forward.
Right, I got it. Sorry, I didn't know that applied to trivial patches.
JN> After this patch, the code looks like
JN> if (!defined $entry->{$check}) {
JN> log_debug(...);
JN> } elsif (defined $query->{$check}) {
JN> ...
JN> } else {
JN> log_debug(...);
JN> }
JN> As a small nit, wouldn't it be more readable with the two !defined()
JN> cases together?
JN> if (!defined $entry->{$check}) {
JN> ...
JN> } elsif (!defined $query->{$check}) {
JN> ...
JN> } else {
JN> ...
JN> }
Because of way the "next ENTRY" line comes out, I like my way slightly
better, but honestly it's fine either way :) If you like, go ahead and
commit the rewrite the way it works for you, I have no objections at all.
Ted
prev parent reply other threads:[~2013-10-08 20:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 14:34 [PATCH] git-credential-netrc: fix uninitialized warning Ted Zlatanov
2013-10-08 19:41 ` Jonathan Nieder
2013-10-08 19:55 ` Ted Zlatanov
2013-10-08 19:58 ` Stefan Beller
2013-10-08 20:04 ` Ted Zlatanov
2013-10-08 20:02 ` Jonathan Nieder
2013-10-08 20:12 ` Ted Zlatanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761t7v7w7.fsf@flea.lifelogs.com \
--to=tzz@lifelogs$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox