From: Ted Zlatanov <tzz@lifelogs•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] git-credential-netrc: fix uninitialized warning
Date: Tue, 08 Oct 2013 15:55:34 -0400 [thread overview]
Message-ID: <87li23v8p5.fsf@flea.lifelogs.com> (raw)
In-Reply-To: <20131008194147.GF9464@google.com> (Jonathan Nieder's message of "Tue, 8 Oct 2013 12:41:47 -0700")
On Tue, 8 Oct 2013 12:41:47 -0700 Jonathan Nieder <jrnieder@gmail•com> wrote:
JN> Ted Zlatanov wrote:
>> Simple patch to avoid unitialized warning and log what we'll do.
JN> Sign-off?
I didn't realize it was a requirement, must I?
JN> [...]
>> --- a/contrib/credential/netrc/git-credential-netrc
>> +++ b/contrib/credential/netrc/git-credential-netrc
>> @@ -369,7 +369,10 @@ sub find_netrc_entry {
>> {
>> my $entry_text = join ', ', map { "$_=$entry->{$_}" } keys %$entry;
>> foreach my $check (sort keys %$query) {
>> - if (defined $query->{$check}) {
>> + if (!defined $entry->{$check}) {
>> + log_debug("OK: entry has no $check token, so any value satisfies check $check");
>> + }
>> + elsif (defined $query->{$check}) {
JN> Style: elsewhere this file seems to use cuddled elses:
JN> } elsif (...) {
Ah, thanks, I missed that.
JN> Or more simply, would it make sense to wrap both 'defined' checks into
JN> a single "if", like so?
JN> if (defined $entry->{$check} && defined $query->{$check}) {
JN> ...
JN> } else {
JN> log_debug(...);
JN> }
I prefer the explicit version because we can issue a more precise
log_debug message.
Ted
next prev parent reply other threads:[~2013-10-08 19:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 14:34 [PATCH] git-credential-netrc: fix uninitialized warning Ted Zlatanov
2013-10-08 19:41 ` Jonathan Nieder
2013-10-08 19:55 ` Ted Zlatanov [this message]
2013-10-08 19:58 ` Stefan Beller
2013-10-08 20:04 ` Ted Zlatanov
2013-10-08 20:02 ` Jonathan Nieder
2013-10-08 20:12 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li23v8p5.fsf@flea.lifelogs.com \
--to=tzz@lifelogs$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox