public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Thomas Rast <trast@inf•ethz.ch>
To: Ramkumar Ramachandra <artagnon@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>, Git List <git@vger•kernel.org>
Subject: Re: [BUG] Highly inconsistent diff UI
Date: Wed, 24 Apr 2013 22:44:27 +0200	[thread overview]
Message-ID: <877gjrpsk4.fsf@hexa.v.cablecom.net> (raw)
In-Reply-To: <CALkWK0=5tE0pXj-XTe4g9LdCO78yrPNwyom5fupF1WTToY2TZw@mail.gmail.com> (Ramkumar Ramachandra's message of "Thu, 25 Apr 2013 00:30:08 +0530")

Ramkumar Ramachandra <artagnon@gmail•com> writes:

> Ramkumar Ramachandra wrote:
>> I'm also considering making the first
>> argument optional (just git log ~rebase.autostash), and defaulting to
>> mean [nearest fork point].
>
> Actually both can be optional.  In A~B, A defaults to [nearest fork
> point] and B defaults to HEAD.
>
>     git log ~
>
> Isn't it beautiful?

Please don't.  The syntax you propose doesn't work for several reasons,
but do we really need one?  How often would you actually use it?

Ok, since you ask, the reasons are:

* Looking for the nearest fork point is expensive and subject to change
  by simply fetching.  I hope you meant "... and exclude its upstream",
  i.e., A defaults to @{u}, which might be at least somewhat useful.

* ~ is already taken; in your syntax, A~1234567 is ambiguous because
  1234567 can both be a SHA1 and a number of generations to go back.

I personally think we have enough magic revision syntax to last at least
another decade.  If you propose to add some, please make a patch that we
can cook in next for a few release cycles and then conduct a straw poll
if people actually use it.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  parent reply	other threads:[~2013-04-24 20:44 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-24 12:23 [BUG] Highly inconsistent diff UI Ramkumar Ramachandra
2013-04-24 16:40 ` Jonathan Nieder
2013-04-24 17:49   ` Junio C Hamano
2013-04-24 18:12     ` Ramkumar Ramachandra
2013-04-24 19:23     ` Jonathan Nieder
2013-04-24 20:02       ` Junio C Hamano
2013-04-24 20:14         ` Ramkumar Ramachandra
2013-04-24 16:44 ` [BUG] " Junio C Hamano
2013-04-24 16:51   ` Ramkumar Ramachandra
2013-04-24 18:11     ` Junio C Hamano
2013-04-24 18:48       ` Ramkumar Ramachandra
2013-04-24 19:00         ` Ramkumar Ramachandra
2013-04-24 19:24           ` Junio C Hamano
2013-04-24 19:29             ` Ramkumar Ramachandra
2013-04-24 21:27               ` Junio C Hamano
2013-04-24 22:06                 ` Ramkumar Ramachandra
2013-04-24 20:44           ` Thomas Rast [this message]
2013-04-24 20:54             ` Ramkumar Ramachandra
2013-04-24 21:02               ` Jonathan Nieder
2013-04-24 21:10                 ` Ramkumar Ramachandra
2013-04-25  7:32               ` Thomas Rast
2013-04-25  8:06                 ` Ramkumar Ramachandra
2013-04-25 16:37                 ` Junio C Hamano
2013-04-25 17:11                   ` Ramkumar Ramachandra
2013-04-25 23:21                     ` Jonathan Nieder
2013-04-25 23:39                       ` Junio C Hamano
2013-04-26 12:34               ` Duy Nguyen
2013-04-24 21:25           ` Phil Hord
2013-04-24 21:23         ` Junio C Hamano
2013-04-24 22:44           ` Ramkumar Ramachandra
2013-04-24 23:17             ` Ramkumar Ramachandra
2013-04-25  5:59               ` Junio C Hamano
2013-04-25  7:51                 ` Ramkumar Ramachandra
2013-04-25  9:30                   ` Ramkumar Ramachandra
2013-04-26 10:47                   ` Ramkumar Ramachandra
2013-04-26 11:35                     ` Ramkumar Ramachandra
2013-04-29 16:32                   ` Junio C Hamano
2013-04-29 18:21                     ` Ramkumar Ramachandra
2013-04-29 18:43                       ` Junio C Hamano
2013-04-29 19:03                         ` Ramkumar Ramachandra
2013-04-29 19:17                           ` Ramkumar Ramachandra
2013-04-29 19:56                           ` Junio C Hamano
2013-04-29 21:12                             ` Ramkumar Ramachandra
2013-04-29 18:32                     ` John Keeping
2013-04-25  4:27             ` Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gjrpsk4.fsf@hexa.v.cablecom.net \
    --to=trast@inf$(echo .)ethz.ch \
    --cc=artagnon@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox