public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Thomas Rast <trast@inf•ethz.ch>
To: Ramkumar Ramachandra <artagnon@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>, Git List <git@vger•kernel.org>
Subject: Re: [BUG] Highly inconsistent diff UI
Date: Thu, 25 Apr 2013 09:32:03 +0200	[thread overview]
Message-ID: <87li87awwc.fsf@linux-k42r.v.cablecom.net> (raw)
In-Reply-To: <CALkWK0kn7mEosWSdWs1Jjx-L32wmL51W=X7ny9BYQMttG1LPvQ@mail.gmail.com> (Ramkumar Ramachandra's message of "Thu, 25 Apr 2013 02:24:17 +0530")

Ramkumar Ramachandra <artagnon@gmail•com> writes:

> Thomas Rast wrote:
>> I personally think we have enough magic revision syntax to last at least
>> another decade.  If you propose to add some, please make a patch that we
>> can cook in next for a few release cycles and then conduct a straw poll
>> if people actually use it.
>
> Isn't it obviously incredibly useful?  I'm working on a topic branch I
> need to send out to git.git, and I want see how my WIP looks: should I
> have to rebase on master just to see this?
>
> Why such a huge resistance against such a small feature?  Can you
> think of ways in which it is myopic (and therefore a pain to keep
> supporting, if we find it undesirable)?

What's the problem with cooking it for a while?  You can start using it
immediately.  I'm just somewhat annoyed that the syntax is rapidly
converging to Perl-style line noise.

I already hate half of the existing syntax, and I cannot remember using
^! (except while investigating what 'git diff C^!' does and why not),
^@, @{-N} (only the related 'git checkout -'), @{date} and @{relative},
^{}, :/foo, and ^{/foo}, *at all*.

In fact I had to look up the second half of that list on the manpage.

That's not to say that they are not useful for *someone*.  But it does
motivate my suggestion that unless we have tried it and *found* that
someone for a new syntax, let's not make it any more magic.

> On a related note- In my opinion, :/ is broken, because it blocks
> composition completely.  I would've really liked {:/quuxery}~3.

I guess this constitutes an argument in my favor (i.e. that the syntax
is too convoluted to understand and know):

^{/foo} is the same as :/foo, except it properly groups.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  parent reply	other threads:[~2013-04-25  7:32 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-24 12:23 [BUG] Highly inconsistent diff UI Ramkumar Ramachandra
2013-04-24 16:40 ` Jonathan Nieder
2013-04-24 17:49   ` Junio C Hamano
2013-04-24 18:12     ` Ramkumar Ramachandra
2013-04-24 19:23     ` Jonathan Nieder
2013-04-24 20:02       ` Junio C Hamano
2013-04-24 20:14         ` Ramkumar Ramachandra
2013-04-24 16:44 ` [BUG] " Junio C Hamano
2013-04-24 16:51   ` Ramkumar Ramachandra
2013-04-24 18:11     ` Junio C Hamano
2013-04-24 18:48       ` Ramkumar Ramachandra
2013-04-24 19:00         ` Ramkumar Ramachandra
2013-04-24 19:24           ` Junio C Hamano
2013-04-24 19:29             ` Ramkumar Ramachandra
2013-04-24 21:27               ` Junio C Hamano
2013-04-24 22:06                 ` Ramkumar Ramachandra
2013-04-24 20:44           ` Thomas Rast
2013-04-24 20:54             ` Ramkumar Ramachandra
2013-04-24 21:02               ` Jonathan Nieder
2013-04-24 21:10                 ` Ramkumar Ramachandra
2013-04-25  7:32               ` Thomas Rast [this message]
2013-04-25  8:06                 ` Ramkumar Ramachandra
2013-04-25 16:37                 ` Junio C Hamano
2013-04-25 17:11                   ` Ramkumar Ramachandra
2013-04-25 23:21                     ` Jonathan Nieder
2013-04-25 23:39                       ` Junio C Hamano
2013-04-26 12:34               ` Duy Nguyen
2013-04-24 21:25           ` Phil Hord
2013-04-24 21:23         ` Junio C Hamano
2013-04-24 22:44           ` Ramkumar Ramachandra
2013-04-24 23:17             ` Ramkumar Ramachandra
2013-04-25  5:59               ` Junio C Hamano
2013-04-25  7:51                 ` Ramkumar Ramachandra
2013-04-25  9:30                   ` Ramkumar Ramachandra
2013-04-26 10:47                   ` Ramkumar Ramachandra
2013-04-26 11:35                     ` Ramkumar Ramachandra
2013-04-29 16:32                   ` Junio C Hamano
2013-04-29 18:21                     ` Ramkumar Ramachandra
2013-04-29 18:43                       ` Junio C Hamano
2013-04-29 19:03                         ` Ramkumar Ramachandra
2013-04-29 19:17                           ` Ramkumar Ramachandra
2013-04-29 19:56                           ` Junio C Hamano
2013-04-29 21:12                             ` Ramkumar Ramachandra
2013-04-29 18:32                     ` John Keeping
2013-04-25  4:27             ` Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87li87awwc.fsf@linux-k42r.v.cablecom.net \
    --to=trast@inf$(echo .)ethz.ch \
    --cc=artagnon@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox