From: Collin Funk <collin.funk1@gmail•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org,
"Carlo Marcelo Arenas Belón" <carenas@gmail•com>,
"Jacob Keller" <jacob.keller@gmail•com>
Subject: Re: [PATCH] cocci: do not directly access the .d_type member in struct dirent
Date: Wed, 18 Jun 2025 12:45:26 -0700 [thread overview]
Message-ID: <87a564sujt.fsf@gmail.com> (raw)
In-Reply-To: <xmqqsejwetli.fsf@gitster.g>
Junio C Hamano <gitster@pobox•com> writes:
>> This change looks good to me. Atleast it will catch code that fails to
>> build on niche platforms, even if it cannot validate existing backup
>> code.
>
> I do not think it is necessarily a good idea to allow building a
> binary that is known to silently misbehave, though.
Yes, but off the top of my head I cannot think of a great way to check
that DTYPE has backup code for systems that do not have d_type.
At least in the case of 'git diff --no-index' the tests will fail if we
do not properly detect a file is a directory. So at least we will likely
know upon running 'make test'. Still that requires manual investigation,
so not perfect, though...
>> Your fix for the 'git diff --no-index' looks correct [1]. I'll build libcurl
>> on an AIX machine I have access to in order to test (not an
>> administrator on it).
>
> I do not think you need libcurl if you only want to test the diff
> --no-index change, but anyway, thanks.
I assumed that it was a hard dependency and could not be disabled. Am I
wrong?
Anyways, it was quick so no worries. I posted my findings [1].
Collin
[1] https://lore.kernel.org/git/87frfwsv4r.fsf@gmail.com/T/#me995c8f49943f0606c236e8e5e9ea8163602e65b
prev parent reply other threads:[~2025-06-18 19:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 17:55 [PATCH] cocci: matching (multiple) identifiers Junio C Hamano
2025-06-18 18:07 ` [PATCH] cocci: do not directly access the .d_type member in struct dirent Junio C Hamano
2025-06-18 18:31 ` Collin Funk
2025-06-18 19:29 ` Junio C Hamano
2025-06-18 19:45 ` Collin Funk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a564sujt.fsf@gmail.com \
--to=collin.funk1@gmail$(echo .)com \
--cc=carenas@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jacob.keller@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox