public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Thomas Rast <tr@thomasrast•ch>
To: Aleksey Vasenev <margtu-fivt@ya•ru>
Cc: git@vger•kernel.org, Benoit Sigoure <tsuna@lrde•epita.fr>,
	Eric Wong <normalperson@yhbt•net>
Subject: Re: [PATCH] git-svn: Support svn:global-ignores property
Date: Sun, 24 Nov 2013 09:42:20 +0100	[thread overview]
Message-ID: <87d2lqgphv.fsf@linux-k42r.v.cablecom.net> (raw)
In-Reply-To: <1385036908-10392-1-git-send-email-margtu-fivt@ya.ru> (Aleksey Vasenev's message of "Thu, 21 Nov 2013 16:28:28 +0400")

Hi Aleksey

Thanks for your patch.  I added Eric Wong to the Cc list; all git-svn
patches should go to him.

Aleksey Vasenev <margtu-fivt@ya•ru> writes:

> ---

Can you write a commit message?  If you need a guideline for what to
write there, consider this snippet from Documentation/SubmittingPatches:

  The body should provide a meaningful commit message, which:

  . explains the problem the change tries to solve, iow, what is wrong
    with the current code without the change.

  . justifies the way the change solves the problem, iow, why the
    result with the change is better.

  . alternate solutions considered but discarded, if any.

In particular, I'm curious about how global-ignores are different from
ordinary ignores.  After reading

  http://svnbook.red-bean.com/en/1.7/svn.advanced.props.special.ignore.html

I don't understand why the above document speaks of a "config area" that
holds the global-ignores configuration, while your patch seems to treat
them as "just another property" set in the same way as existing
svn:ignore.  How does this work?


>  Documentation/git-svn.txt | 12 ++++++------
>  git-svn.perl              | 46 ++++++++++++++++++++++++++++++++--------------
>  2 files changed, 38 insertions(+), 20 deletions(-)

Can you add a test or two?

-- 
Thomas Rast
tr@thomasrast•ch

next prev parent reply	other threads:[~2013-11-24  8:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21 10:41 [PATCH] git-svn: Support svn:global-ignores property Aleksey Vasenev
2013-11-21 12:28 ` Aleksey Vasenev
2013-11-24  8:42   ` Thomas Rast [this message]
2013-12-16 22:23   ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2lqgphv.fsf@linux-k42r.v.cablecom.net \
    --to=tr@thomasrast$(echo .)ch \
    --cc=git@vger$(echo .)kernel.org \
    --cc=margtu-fivt@ya$(echo .)ru \
    --cc=normalperson@yhbt$(echo .)net \
    --cc=tsuna@lrde$(echo .)epita.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox