From: Thomas Rast <trast@inf•ethz.ch>
To: Felipe Contreras <felipe.contreras@gmail•com>
Cc: <git@vger•kernel.org>
Subject: Re: [PATCH] test: fix post rewrite hook report
Date: Thu, 30 May 2013 16:35:29 +0200 [thread overview]
Message-ID: <87d2s8fscu.fsf@linux-k42r.v.cablecom.net> (raw)
In-Reply-To: <1369921595-30514-1-git-send-email-felipe.contreras@gmail.com> (Felipe Contreras's message of "Thu, 30 May 2013 08:46:35 -0500")
Felipe Contreras <felipe.contreras@gmail•com> writes:
> First expected, then actual.
Ack. That is the prevalent (almost universal, but not quite) style.
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail•com>
> ---
> t/t5407-post-rewrite-hook.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t5407-post-rewrite-hook.sh b/t/t5407-post-rewrite-hook.sh
> index baa670c..ea2e0d4 100755
> --- a/t/t5407-post-rewrite-hook.sh
> +++ b/t/t5407-post-rewrite-hook.sh
> @@ -31,8 +31,8 @@ clear_hook_input () {
> }
>
> verify_hook_input () {
> - test_cmp "$TRASH_DIRECTORY"/post-rewrite.args expected.args &&
> - test_cmp "$TRASH_DIRECTORY"/post-rewrite.data expected.data
> + test_cmp expected.args "$TRASH_DIRECTORY"/post-rewrite.args &&
> + test_cmp expected.data "$TRASH_DIRECTORY"/post-rewrite.data
> }
>
> test_expect_success 'git commit --amend' '
--
Thomas Rast
trast@{inf,student}.ethz.ch
prev parent reply other threads:[~2013-05-30 14:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 13:46 [PATCH] test: fix post rewrite hook report Felipe Contreras
2013-05-30 14:35 ` Thomas Rast [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2s8fscu.fsf@linux-k42r.v.cablecom.net \
--to=trast@inf$(echo .)ethz.ch \
--cc=felipe.contreras@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox