* [PATCH] test: fix post rewrite hook report
@ 2013-05-30 13:46 Felipe Contreras
2013-05-30 14:35 ` Thomas Rast
0 siblings, 1 reply; 2+ messages in thread
From: Felipe Contreras @ 2013-05-30 13:46 UTC (permalink / raw)
To: git; +Cc: Thomas Rast, Felipe Contreras
First expected, then actual.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail•com>
---
t/t5407-post-rewrite-hook.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t5407-post-rewrite-hook.sh b/t/t5407-post-rewrite-hook.sh
index baa670c..ea2e0d4 100755
--- a/t/t5407-post-rewrite-hook.sh
+++ b/t/t5407-post-rewrite-hook.sh
@@ -31,8 +31,8 @@ clear_hook_input () {
}
verify_hook_input () {
- test_cmp "$TRASH_DIRECTORY"/post-rewrite.args expected.args &&
- test_cmp "$TRASH_DIRECTORY"/post-rewrite.data expected.data
+ test_cmp expected.args "$TRASH_DIRECTORY"/post-rewrite.args &&
+ test_cmp expected.data "$TRASH_DIRECTORY"/post-rewrite.data
}
test_expect_success 'git commit --amend' '
--
1.8.3.rc3.312.g47657de
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] test: fix post rewrite hook report
2013-05-30 13:46 [PATCH] test: fix post rewrite hook report Felipe Contreras
@ 2013-05-30 14:35 ` Thomas Rast
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Rast @ 2013-05-30 14:35 UTC (permalink / raw)
To: Felipe Contreras; +Cc: git
Felipe Contreras <felipe.contreras@gmail•com> writes:
> First expected, then actual.
Ack. That is the prevalent (almost universal, but not quite) style.
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail•com>
> ---
> t/t5407-post-rewrite-hook.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t5407-post-rewrite-hook.sh b/t/t5407-post-rewrite-hook.sh
> index baa670c..ea2e0d4 100755
> --- a/t/t5407-post-rewrite-hook.sh
> +++ b/t/t5407-post-rewrite-hook.sh
> @@ -31,8 +31,8 @@ clear_hook_input () {
> }
>
> verify_hook_input () {
> - test_cmp "$TRASH_DIRECTORY"/post-rewrite.args expected.args &&
> - test_cmp "$TRASH_DIRECTORY"/post-rewrite.data expected.data
> + test_cmp expected.args "$TRASH_DIRECTORY"/post-rewrite.args &&
> + test_cmp expected.data "$TRASH_DIRECTORY"/post-rewrite.data
> }
>
> test_expect_success 'git commit --amend' '
--
Thomas Rast
trast@{inf,student}.ethz.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-30 14:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-30 13:46 [PATCH] test: fix post rewrite hook report Felipe Contreras
2013-05-30 14:35 ` Thomas Rast
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox