public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: greened@obbligato•org (David A. Greene)
To: Ramkumar Ramachandra <artagnon@gmail•com>
Cc: David Greene <dag@cray•com>, git@vger•kernel.org
Subject: Re: git-subtree
Date: Thu, 05 Jan 2012 09:03:38 -0600	[thread overview]
Message-ID: <87ipkq199w.fsf@smith.obbligato.org> (raw)
In-Reply-To: <CALkWK0nU9iO_6CCbWw8c_Fz=xodkaAW4300Jpc7M7D+kBP=QRg@mail.gmail.com> (Ramkumar Ramachandra's message of "Thu, 5 Jan 2012 16:58:22 +0530")

Ramkumar Ramachandra <artagnon@gmail•com> writes:

> Hi David,
>
> David Greene wrote:
>> I have a patch ready.
>> How does the git community want the patch presented?
>
> Please read and follow the guidelines listed in
> Documentation/SubmittingPatches.  The TL;DR version is: break it up
> into logical reviewable commits based on the current `master` and use
> git format-patch/ git send-email to send those commits to this mailing
> list.

I've read that document.  The issue is that I didn't develop the code,
Avery did.  This is a completely new tool for git and I don't have the
first idea of what "logical" chunks would look like.  I assume, for
example, that we'd want the first "chunk" to actually work and do
something interesting.  I can go spend a bunch of time to see if I can
grok enough to create these chunks but I wanted to check first and make
sure that would be absolutely necessary.  It's a lot of time to learn a
completely new codebase.  I was hoping to submit something soon and then
learn the codebase gradually during maintenance/further development.

How have completely new tools be introduced into the git mainline in the
past?

Thanks!

                              -Dave

next prev parent reply	other threads:[~2012-01-05 15:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04 15:53 git-subtree David Greene
2012-01-05 11:28 ` git-subtree Ramkumar Ramachandra
2012-01-05 15:03   ` David A. Greene [this message]
2012-01-05 15:32     ` git-subtree Ramkumar Ramachandra
2012-01-05 16:33       ` git-subtree David A. Greene
2012-01-06  1:53         ` git-subtree David A. Greene
2012-01-05 22:18       ` git-subtree David A. Greene
2012-01-05 15:47     ` git-subtree Jeff King
2012-01-05 16:26       ` git-subtree David A. Greene
2012-01-29 22:07         ` git-subtree David A. Greene
2012-01-30 16:56           ` git-subtree David A. Greene
2012-01-05 22:16       ` git-subtree David A. Greene
2012-01-05 15:53 ` git-subtree Junio C Hamano
2012-01-05 16:48   ` git-subtree David A. Greene
2012-01-05 22:19   ` git-subtree David A. Greene
  -- strict thread matches above, loose matches on Subject: below --
2021-11-14 10:11 git-subtree tqfx su
2021-11-15  8:12 ` git-subtree Fabian Stelzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipkq199w.fsf@smith.obbligato.org \
    --to=greened@obbligato$(echo .)org \
    --cc=artagnon@gmail$(echo .)com \
    --cc=dag@cray$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox