From: David Kastrup <dak@gnu•org>
To: Erik Faye-Lund <kusmabite@gmail•com>
Cc: Chris Packham <judge.packham@gmail•com>,
Jeremiah Mahler <jmmahler@gmail•com>,
GIT Mailing-list <git@vger•kernel.org>
Subject: Re: [PATCH 1/5] progress.c: replace signal() with sigaction()
Date: Wed, 28 May 2014 11:11:05 +0200 [thread overview]
Message-ID: <87k396i7yu.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <CABPQNSbRZS6DuNOLpWKtx6150sz20GjQ6RaakiSdi7FEQW5X3Q@mail.gmail.com> (Erik Faye-Lund's message of "Wed, 28 May 2014 10:48:35 +0200")
Erik Faye-Lund <kusmabite@gmail•com> writes:
> On Wed, May 28, 2014 at 10:19 AM, David Kastrup <dak@gnu•org> wrote:
>> Chris Packham <judge.packham@gmail•com> writes:
>>
>>> On 28/05/14 18:14, Jeremiah Mahler wrote:
>>>> static void clear_progress_signal(void)
>>>> {
>>>> struct itimerval v = {{0,},};
>>>> + struct sigaction sa;
>>>> +
>>>> + memset(&sa, 0, sizeof(sa));
>>>> + sa.sa_handler = SIG_IGN;
>>>
>>> A C99 initialiser here would save the call to memset. Unfortunately
>>> Documentation/CodingGuidelines is fairly clear on not using C99
>>> initialisers, given the fact we're now at git 2.0 maybe it's time to
>>> revisit this policy?
>>
>> If I look at the initialization of v in the context immediately above
>> the new code, it would appear that somebody already revisited this
>> policy.
>
> Huh, the initialization of v doesn't use C99-features...?
Well, for me anything post-K&R apparently is C99.
Cf
<URL:http://computer-programming-forum.com/47-c-language/859a1b6693a0ddc5.htm>
I have to admit that gcc -c -ansi -std=c89 -pedantic does not complain,
so that makes it quite probable that I was erring somewhat on the side
of the ancient ones and zeros.
--
David Kastrup
next prev parent reply other threads:[~2014-05-28 9:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 6:14 [PATCH 0/5] replace signal() with sigaction() Jeremiah Mahler
2014-05-28 6:14 ` [PATCH 1/5] progress.c: " Jeremiah Mahler
2014-05-28 8:07 ` Chris Packham
2014-05-28 8:19 ` David Kastrup
2014-05-28 8:48 ` Erik Faye-Lund
2014-05-28 9:11 ` David Kastrup [this message]
2014-05-28 17:35 ` Junio C Hamano
2014-05-28 15:45 ` Jeremiah Mahler
2014-05-28 6:14 ` [PATCH 2/5] daemon.c run_service(): " Jeremiah Mahler
2014-05-28 6:14 ` [PATCH 3/5] daemon.c child_handler(): " Jeremiah Mahler
2014-05-28 6:14 ` [PATCH 4/5] daemon.c service_loop(): " Jeremiah Mahler
2014-05-28 6:14 ` [PATCH 5/5] connect.c: " Jeremiah Mahler
2014-05-28 7:40 ` [PATCH 0/5] " Johannes Sixt
2014-05-28 8:11 ` Chris Packham
2014-05-28 8:23 ` Erik Faye-Lund
2014-05-28 16:11 ` Jeremiah Mahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k396i7yu.fsf@fencepost.gnu.org \
--to=dak@gnu$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=jmmahler@gmail$(echo .)com \
--cc=judge.packham@gmail$(echo .)com \
--cc=kusmabite@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox