public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Sergey Organov <sorganov@gmail•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org
Subject: Re: What's cooking in git.git (Aug 2020, #02; Mon, 10)
Date: Wed, 12 Aug 2020 00:26:17 +0300	[thread overview]
Message-ID: <87lfik50xy.fsf@osv.gnss.ru> (raw)
In-Reply-To: <xmqqy2ml7wrd.fsf@gitster.c.googlers.com> (Junio C. Hamano's message of "Tue, 11 Aug 2020 13:28:22 -0700")

Junio C Hamano <gitster@pobox•com> writes:

> Sergey Organov <sorganov@gmail•com> writes:
>
>> And I asked you to postpone that in <875z9v7b0k.fsf@osv•gnss.ru> for
>> which I got no answer. I repeat it here for convenience:
>>
>> "
>> For now, can we leave these patches as-is and then add additional tests
>> on top, please? I'm afraid that adding them now will force me to rewrite
>> current descriptions, as the result won't be minimal anymore, and I
>> feel uneasy about writing commit messages for these permuted tests
>> anyway.
>> "
>
> I was expecting just one case I mentioned in the first message and
> nothing else, which is crucial to highlight how --first-parent's
> "implication" works with explicit --diff-merges.
>
> Full "permutated tests" was what you brought up in the discussion,
> but I already said it was overkill to your response before you said
> the above.  The "minimal" would be the posted patch plus a missing
> "first-parent comes before --diff-merges=off" test filled in.

I've sent the patch before I saw this, please see
<87tux93pku.fsf@osv•gnss.ru>.

Is it OK with you?

Thanks,
-- Sergey

next prev parent reply	other threads:[~2020-08-11 21:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10 19:44 What's cooking in git.git (Aug 2020, #02; Mon, 10) Junio C Hamano
2020-08-11  5:01 ` Eric Sunshine
2020-08-11 19:24   ` Junio C Hamano
2020-08-11  6:53 ` Jeff King
2020-08-11  9:33   ` Patrick Steinhardt
2020-08-11  9:59   ` brian m. carlson
2020-08-11 10:10 ` Sergey Organov
2020-08-11 19:23   ` Junio C Hamano
2020-08-11 19:34     ` Sergey Organov
2020-08-11 20:17       ` Sergey Organov
2020-08-11 21:36         ` Junio C Hamano
2020-08-12  8:15           ` Sergey Organov
2020-08-11 20:28       ` Junio C Hamano
2020-08-11 21:26         ` Sergey Organov [this message]
2020-08-11 22:12           ` Junio C Hamano
2020-08-11 13:48 ` Taylor Blau
2020-08-11 14:27 ` Matheus Tavares Bernardino
2020-08-11 19:20   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfik50xy.fsf@osv.gnss.ru \
    --to=sorganov@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox