From: Sergey Organov <sorganov@gmail•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org
Subject: Re: What's cooking in git.git (Aug 2020, #02; Mon, 10)
Date: Wed, 12 Aug 2020 11:15:50 +0300 [thread overview]
Message-ID: <87eeoce0uh.fsf@osv.gnss.ru> (raw)
In-Reply-To: <xmqqh7t89870.fsf@gitster.c.googlers.com> (Junio C. Hamano's message of "Tue, 11 Aug 2020 14:36:03 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> Sergey Organov <sorganov@gmail•com> writes:
>
>> Here is the patch you've asked for, separately, as I honestly believe it
>> does not belong to the series in question themselves. This is on top of
>> the series.
>
> Well, the tip commit's title being "add test for --diff-merges=off",
> testing it standalone as well as in different ways to combine with
> another option that potentially interacts with it would make the
> commit complete, I would think.
My point is that this set of commits is essentially "make
--diff-merges=on a synonym for --no-diff-merges", so it should only
include the same test(s) that exist for --no-diff-merges.
If new tests are to be added, they should have been added before the
series, or after them, with their own reasoning, I think. Yeah, not a
big deal, just a bit of perfectionism here.
Thanks,
-- Sergey
next prev parent reply other threads:[~2020-08-12 8:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 19:44 What's cooking in git.git (Aug 2020, #02; Mon, 10) Junio C Hamano
2020-08-11 5:01 ` Eric Sunshine
2020-08-11 19:24 ` Junio C Hamano
2020-08-11 6:53 ` Jeff King
2020-08-11 9:33 ` Patrick Steinhardt
2020-08-11 9:59 ` brian m. carlson
2020-08-11 10:10 ` Sergey Organov
2020-08-11 19:23 ` Junio C Hamano
2020-08-11 19:34 ` Sergey Organov
2020-08-11 20:17 ` Sergey Organov
2020-08-11 21:36 ` Junio C Hamano
2020-08-12 8:15 ` Sergey Organov [this message]
2020-08-11 20:28 ` Junio C Hamano
2020-08-11 21:26 ` Sergey Organov
2020-08-11 22:12 ` Junio C Hamano
2020-08-11 13:48 ` Taylor Blau
2020-08-11 14:27 ` Matheus Tavares Bernardino
2020-08-11 19:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeoce0uh.fsf@osv.gnss.ru \
--to=sorganov@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox