From: Sergei Organov <osv@javad•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: "Ask Bjørn Hansen" <ask@develooper•com>, git@vger•kernel.org
Subject: Re: [PATCH] Don't add To: recipients to the Cc: header
Date: Fri, 23 Nov 2007 20:53:41 +0300 [thread overview]
Message-ID: <87lk8orgpm.fsf@osv.gnss.ru> (raw)
In-Reply-To: <7vr6ikk6rf.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Tue\, 20 Nov 2007 12\:21\:24 -0800")
Junio C Hamano <gitster@pobox•com> writes:
> Sergei Organov <osv@javad•com> writes:
>
>> Junio C Hamano <gitster@pobox•com> writes:
>> [...]
>>> Oops, forgot to say "no need to resend". I asked only because I
>>> wanted an independent datapoint for Emacs diff mode breakage.
>>
>> I bet I can damage any patch using any editor ;)
>>
>> More interesting is what version of Emacs it was?
>
> To be fair and honest, I do not think there is a simple fix for
> this, although it probably is possible to fix it.
>
> What is causing the "breakage" is the fact that format-patch
> output ends with the signature delimiter line "^-- $" that
> immediately follows the patch text.
Exactly. What causes breakage is the fact that the '-' character (as
well as '+', ' ', '!', '#', and '\'), being the first symbol of a line
has special meaning in the diff format.
Therefore it seems that format-patch should better put one empty line
after the last diff hunk and before the signature. Any objections?
--
Sergei.
next prev parent reply other threads:[~2007-11-23 17:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 11:00 [PATCH] Don't add To: recipients to the Cc: header Ask Bjørn Hansen
2007-11-19 11:05 ` Ask Bjørn Hansen
2007-11-20 7:52 ` Junio C Hamano
2007-11-20 9:36 ` Ask Bjørn Hansen
2007-11-20 19:04 ` Junio C Hamano
2007-11-20 19:18 ` Sergei Organov
2007-11-20 20:21 ` Junio C Hamano
2007-11-23 17:53 ` Sergei Organov [this message]
2007-11-23 19:48 ` Junio C Hamano
2007-11-23 20:18 ` Sergei Organov
2007-11-23 23:54 ` Junio C Hamano
2007-11-26 13:48 ` Sergei Organov
2007-11-26 16:53 ` Junio C Hamano
2007-11-26 18:29 ` Sergei Organov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lk8orgpm.fsf@osv.gnss.ru \
--to=osv@javad$(echo .)com \
--cc=ask@develooper$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox