From: Sergei Organov <osv@javad•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: "Ask Bjørn Hansen" <ask@develooper•com>, git@vger•kernel.org
Subject: Re: [PATCH] Don't add To: recipients to the Cc: header
Date: Mon, 26 Nov 2007 21:29:11 +0300 [thread overview]
Message-ID: <8763zoq2rs.fsf@osv.gnss.ru> (raw)
In-Reply-To: <7v3autgd8q.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Mon\, 26 Nov 2007 08\:53\:09 -0800")
Junio C Hamano <gitster@pobox•com> writes:
> Sergei Organov <osv@javad•com> writes:
>
>>> GNU folks even managed to insert text that allows a completely empty
>>> line (not a line with a single SP on it) to express a context line
>>> that is empty, which means...
>>
>> Really? That's a surprise for me. What I can tell for sure, Emacs' diff
>> mode doesn't support this, as it does interpret plain empty line as a
>> hunk delimiter, at least in Emacs 22.1.
>
> See b507b465f7831612b9d9fc643e3e5218b64e5bfa (git-apply: prepare for
> upcoming GNU diff -u format change). Around the time that eventually
> lead to this commit (mid October 2006) there was a discussion on this
> mailing list on the issue, too. I do not doubt you checked with your
> version of Emacs diff mode that it does not support this yet, but it's
> only prudent to assume that a new version someday will.
Thanks, -- it was interesting to read corresponding discussions.
Due to this change in GNU diff, it seems that empty line is indeed a
wrong choice for syntactic hunk separator :( I wonder if there is a
common way to say "here the patch ends" then[1]? My best guess is that
===
will do.
[1] I've checked bzr and hg. Bzr uses empty line for that (followed by
"# Begin bundle" line) in their "merge directive" format. Not
Emacs-friendly either :( Hg's "export" just EOFs after the patch.
--
Sergei.
prev parent reply other threads:[~2007-11-26 18:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 11:00 [PATCH] Don't add To: recipients to the Cc: header Ask Bjørn Hansen
2007-11-19 11:05 ` Ask Bjørn Hansen
2007-11-20 7:52 ` Junio C Hamano
2007-11-20 9:36 ` Ask Bjørn Hansen
2007-11-20 19:04 ` Junio C Hamano
2007-11-20 19:18 ` Sergei Organov
2007-11-20 20:21 ` Junio C Hamano
2007-11-23 17:53 ` Sergei Organov
2007-11-23 19:48 ` Junio C Hamano
2007-11-23 20:18 ` Sergei Organov
2007-11-23 23:54 ` Junio C Hamano
2007-11-26 13:48 ` Sergei Organov
2007-11-26 16:53 ` Junio C Hamano
2007-11-26 18:29 ` Sergei Organov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763zoq2rs.fsf@osv.gnss.ru \
--to=osv@javad$(echo .)com \
--cc=ask@develooper$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox