From: Thomas Rast <trast@inf•ethz.ch>
To: "David A. Greene" <greened@obbligato•org>
Cc: Junio C Hamano <gitster@pobox•com>, Jeff King <peff@peff•net>,
<git@vger•kernel.org>, Avery Pennarun <apenwarr@gmail•com>
Subject: Re: git-subtree Ready #2
Date: Tue, 21 Feb 2012 10:07:44 +0100 [thread overview]
Message-ID: <87sji4k10f.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <87ehtowxu7.fsf@smith.obbligato.org> (David A. Greene's message of "Mon, 20 Feb 2012 23:37:52 -0600")
greened@obbligato•org (David A. Greene) writes:
>> -GIT_BUILD_DIR="$TEST_DIRECTORY"/..
>> +
>> +if test -z "$GIT_BUILD_DIR"
>> +then
>> + echo Here
>> + # We allow tests to override this, in case they want to run tests
>> + # outside of t/, e.g. for running tests on the test library
>> + # itself.
>> + GIT_BUILD_DIR="$TEST_DIRECTORY"/..
>> +fi
>
> I'll put a patch together with a more extensive explanation. Basically,
> tests run outside of the top-level t/ directory don't work because there
> are all sort of assumptions in test-lib.sh about where they live. There
> are comments in test-lib.sh indicating that it should support tests in
> other directories but I could not make it work out of the box.
Note that this will conflict with tr/perftest, which is already in next.
It had a similar override, but then made do with the existing
GIT_TEST_INSTALLED facility. I think you do need the above here,
because you are not sourcing test-lib from the directory where the test
lives. It may then be cleaner to again use GIT_BUILD_DIR in
t/perf/perf-lib.sh since it does not require knowledge (outside of
test-lib) that $GIT_BUILD_DIR/bin-wrappers/ holds the binaries.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2012-02-21 9:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 17:35 git-subtree Ready #2 David A. Greene
2012-02-11 18:03 ` Junio C Hamano
2012-02-11 19:22 ` David A. Greene
2012-02-15 4:30 ` David A. Greene
2012-02-15 5:08 ` Jeff King
2012-02-15 5:31 ` David A. Greene
2012-02-16 4:07 ` David A. Greene
2012-02-20 19:34 ` David A. Greene
2012-02-20 20:53 ` Jeff King
2012-02-20 23:14 ` Junio C Hamano
2012-02-21 5:37 ` David A. Greene
2012-02-21 6:34 ` Junio C Hamano
2012-02-21 7:10 ` Junio C Hamano
2012-02-21 8:44 ` Junio C Hamano
2012-02-21 9:07 ` Thomas Rast [this message]
2012-02-24 1:19 ` Avery Pennarun
2012-02-24 20:56 ` Junio C Hamano
2012-02-24 23:57 ` Avery Pennarun
2012-02-25 5:00 ` David A. Greene
2012-02-25 9:00 ` Junio C Hamano
2012-02-25 15:00 ` David A. Greene
2012-02-27 21:06 ` Junio C Hamano
2012-02-27 21:21 ` Jeff King
2012-02-27 21:23 ` Jeff King
2012-02-28 2:04 ` Jakub Narebski
2012-02-28 22:42 ` Avery Pennarun
2012-03-02 3:42 ` David A. Greene
2012-02-21 5:31 ` David A. Greene
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sji4k10f.fsf@thomas.inf.ethz.ch \
--to=trast@inf$(echo .)ethz.ch \
--cc=apenwarr@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=greened@obbligato$(echo .)org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox