From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Phillip Wood" <phillip.wood@dunelm•org.uk>,
"Johannes Sixt" <j6t@kdbg•org>,
"Git Mailing List" <git@vger•kernel.org>
Subject: Re: How dangerous is --committer-date-is-author-date these days?
Date: Mon, 30 Sep 2024 16:49:32 +0200 [thread overview]
Message-ID: <93041214-4774-49eb-b8bd-24648134cded@app.fastmail.com> (raw)
In-Reply-To: <6d6b2ff0-b4e4-4442-a3be-9b31742db280@gmail.com>
As a Git user, I don’t understand why some people want to fiddle with
this field in rewrite operations. It’s very hidden (apparently you have
to use something like `git log --format=fuller` to reveal it).
I can’t speak for power users. But regular users? Well I see questions
about being very deliberate about setting this field on rewrite
operations on StackOverflow (at least one time). But I can only guess
*why* they are particular about it (this part is often not explained).
And I don’t know if they know the true “spirit” behind the field.
Maybe they are of the impression that committer date and author date
*ought to* be the same?
Of course the aforementioned patch by Philip[1] was done in order to
make the available options between the two rebase backends consistent.
This option `--committer-date-is-author-date` was first added in
3f01ad66549 (am: Add --committer-date-is-author-date option,
2009-01-22). The email that I could find[2] for the patch has no
follow-up replies.
That option was added to git-am(1). So not a rewrite operation. Rather
a “lie” (as it was documented on that commit).
Which ties me back to the “regular user” point: most people don’t use
email workflows. So adding commits from email is not something they do.
Surely most uses of this option is in git-rebase(1). And most users
might take for a given that author=committer. In turn also that
committer-date=author-date.
Again for those who care enough to hunt down this long (words) option.
🔗 1: https://lore.kernel.org/git/20200817174004.92455-4-phillip.wood123@gmail.com/
🔗 2: https://lore.kernel.org/git/20090124101750.6117@nanako3.lavabit.com/
--
Kristoffer Haugsbakk
next prev parent reply other threads:[~2024-09-30 14:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-28 6:59 How dangerous is --committer-date-is-author-date these days? Johannes Sixt
2024-09-28 9:49 ` Phillip Wood
2024-09-28 10:04 ` Phillip Wood
2024-09-30 14:49 ` Kristoffer Haugsbakk [this message]
2024-09-30 17:08 ` Junio C Hamano
2025-10-08 20:41 ` SZEDER Gábor
2025-10-08 19:45 ` [PATCH] doc: warn against --committer-date-is-author-date kristofferhaugsbakk
2025-10-09 13:46 ` Phillip Wood
2025-10-09 14:31 ` Kristoffer Haugsbakk
2025-10-09 20:47 ` Kristoffer Haugsbakk
2025-10-09 21:58 ` Junio C Hamano
2025-10-09 22:56 ` Kristoffer Haugsbakk
2025-10-09 21:41 ` Junio C Hamano
2025-10-09 21:57 ` Kristoffer Haugsbakk
2025-10-11 9:15 ` Johannes Sixt
2025-10-16 14:13 ` Kristoffer Haugsbakk
2025-10-16 15:12 ` Kristoffer Haugsbakk
2025-10-16 15:28 ` Johannes Sixt
2025-10-16 15:42 ` Kristoffer Haugsbakk
2025-10-16 16:23 ` Junio C Hamano
2025-11-19 16:27 ` Kristoffer Haugsbakk
2025-11-20 16:26 ` [PATCH v2] " kristofferhaugsbakk
2025-11-20 17:19 ` Johannes Sixt
2025-11-26 16:02 ` Phillip Wood
2025-11-27 6:30 ` Kristoffer Haugsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93041214-4774-49eb-b8bd-24648134cded@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
--cc=phillip.wood@dunelm$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox