From: "Kristoffer Haugsbakk" <code@khaugsbakk•name>
To: "Junio C Hamano" <gitster@pobox•com>, "Johannes Sixt" <j6t@kdbg•org>
Cc: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>,
git@vger•kernel.org, "Phillip Wood" <phillip.wood@dunelm•org.uk>
Subject: Re: [PATCH] doc: warn against --committer-date-is-author-date
Date: Wed, 19 Nov 2025 17:27:15 +0100 [thread overview]
Message-ID: <da44a9ce-6e04-43c3-be1a-5db640c20e98@app.fastmail.com> (raw)
In-Reply-To: <xmqqbjm695p4.fsf@gitster.g>
On Thu, Oct 16, 2025, at 18:23, Junio C Hamano wrote:
> Johannes Sixt <j6t@kdbg•org> writes:
>>[snip]
>> I do not like the latter. If you do not like the former, I wouldn't mind
>> not adding the sentence. The warning should be sufficient.
>
> But stepping back a bit, if we truly want to discourage the use of
> it, perhaps we should officially deprecate and schedule it for
> removal? If we are *not* brave enough to back such a move, then
> perhaps we ourselves are not yet convinced that this should be
> discouraged?
>
> My preference is to stop at describing, in WARNING or NOTES, what
> the use case that triggered the addition of this option was and
> declaring that the use case does not make any sense (your "who would
> apply the same series twice on the same base? just keep the result
> on a branch and reuse" would be fine), but without saying "Do not
> use this option". In other words, the message is "We'd give a long
> rope that we do not think is very useful, but it is up to you to get
> yourself tangled in it".
I agree with just warning.
next prev parent reply other threads:[~2025-11-19 16:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-28 6:59 How dangerous is --committer-date-is-author-date these days? Johannes Sixt
2024-09-28 9:49 ` Phillip Wood
2024-09-28 10:04 ` Phillip Wood
2024-09-30 14:49 ` Kristoffer Haugsbakk
2024-09-30 17:08 ` Junio C Hamano
2025-10-08 20:41 ` SZEDER Gábor
2025-10-08 19:45 ` [PATCH] doc: warn against --committer-date-is-author-date kristofferhaugsbakk
2025-10-09 13:46 ` Phillip Wood
2025-10-09 14:31 ` Kristoffer Haugsbakk
2025-10-09 20:47 ` Kristoffer Haugsbakk
2025-10-09 21:58 ` Junio C Hamano
2025-10-09 22:56 ` Kristoffer Haugsbakk
2025-10-09 21:41 ` Junio C Hamano
2025-10-09 21:57 ` Kristoffer Haugsbakk
2025-10-11 9:15 ` Johannes Sixt
2025-10-16 14:13 ` Kristoffer Haugsbakk
2025-10-16 15:12 ` Kristoffer Haugsbakk
2025-10-16 15:28 ` Johannes Sixt
2025-10-16 15:42 ` Kristoffer Haugsbakk
2025-10-16 16:23 ` Junio C Hamano
2025-11-19 16:27 ` Kristoffer Haugsbakk [this message]
2025-11-20 16:26 ` [PATCH v2] " kristofferhaugsbakk
2025-11-20 17:19 ` Johannes Sixt
2025-11-26 16:02 ` Phillip Wood
2025-11-27 6:30 ` Kristoffer Haugsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da44a9ce-6e04-43c3-be1a-5db640c20e98@app.fastmail.com \
--to=code@khaugsbakk$(echo .)name \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=j6t@kdbg$(echo .)org \
--cc=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=phillip.wood@dunelm$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox