From: Patrick Steinhardt <ps@pks•im>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail•com>
Cc: "Alex Xu (Hello71)" <alex_y_xu@yahoo•ca>, git@vger•kernel.org
Subject: Re: [PATCH] meson: move config-list from libgit to builtin
Date: Mon, 13 Jan 2025 16:42:21 +0100 [thread overview]
Message-ID: <Z4U0XengqX_a7ywU@pks.im> (raw)
In-Reply-To: <efb8b6d1-c06a-4f73-89bb-6d164ab03cfa@app.fastmail.com>
On Mon, Jan 13, 2025 at 03:17:08PM +0100, Kristoffer Haugsbakk wrote:
> On Mon, Jan 13, 2025, at 14:46, Alex Xu (Hello71) wrote:
> > config-list is used by builtin/help.c, not libgit. this matches Makefile
> > dependencies
> >
> > Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo•ca>
> > ---
> > meson.build | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meson.build b/meson.build
> > index 0064eb64f5..ef3604a17f 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -614,7 +614,7 @@ libgit_sources += custom_target(
> > env: script_environment,
> > )
> >
> > -libgit_sources += custom_target(
> > +builtin_sources += custom_target(
>
> Looks like the same change is in another patch from today
>
> https://lore.kernel.org/git/20250113-b4-pks-meson-additions-v1-3-97f6a93f691d@pks.im/
Yup, indeed :) I'd prefer to go with my series as it also contains a
couple more additions, and because it also fixes the same issue for
"hook-list.h".
Thanks for your contribution!
Patrick
prev parent reply other threads:[~2025-01-13 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250113134632.21592-1-alex_y_xu.ref@yahoo.ca>
2025-01-13 13:46 ` [PATCH] meson: move config-list from libgit to builtin Alex Xu (Hello71)
2025-01-13 14:17 ` Kristoffer Haugsbakk
2025-01-13 15:42 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4U0XengqX_a7ywU@pks.im \
--to=ps@pks$(echo .)im \
--cc=alex_y_xu@yahoo$(echo .)ca \
--cc=git@vger$(echo .)kernel.org \
--cc=kristofferhaugsbakk@fastmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox