From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Alex Xu (Hello71)" <alex_y_xu@yahoo•ca>,
git@vger•kernel.org, "Patrick Steinhardt" <ps@pks•im>
Subject: Re: [PATCH] meson: move config-list from libgit to builtin
Date: Mon, 13 Jan 2025 15:17:08 +0100 [thread overview]
Message-ID: <efb8b6d1-c06a-4f73-89bb-6d164ab03cfa@app.fastmail.com> (raw)
In-Reply-To: <20250113134632.21592-1-alex_y_xu@yahoo.ca>
On Mon, Jan 13, 2025, at 14:46, Alex Xu (Hello71) wrote:
> config-list is used by builtin/help.c, not libgit. this matches Makefile
> dependencies
>
> Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo•ca>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 0064eb64f5..ef3604a17f 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -614,7 +614,7 @@ libgit_sources += custom_target(
> env: script_environment,
> )
>
> -libgit_sources += custom_target(
> +builtin_sources += custom_target(
Looks like the same change is in another patch from today
https://lore.kernel.org/git/20250113-b4-pks-meson-additions-v1-3-97f6a93f691d@pks.im/
--
Kristoffer Haugsbakk
next prev parent reply other threads:[~2025-01-13 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250113134632.21592-1-alex_y_xu.ref@yahoo.ca>
2025-01-13 13:46 ` [PATCH] meson: move config-list from libgit to builtin Alex Xu (Hello71)
2025-01-13 14:17 ` Kristoffer Haugsbakk [this message]
2025-01-13 15:42 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efb8b6d1-c06a-4f73-89bb-6d164ab03cfa@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=alex_y_xu@yahoo$(echo .)ca \
--cc=git@vger$(echo .)kernel.org \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox