* [PATCH] meson: move config-list from libgit to builtin
[not found] <20250113134632.21592-1-alex_y_xu.ref@yahoo.ca>
@ 2025-01-13 13:46 ` Alex Xu (Hello71)
2025-01-13 14:17 ` Kristoffer Haugsbakk
0 siblings, 1 reply; 3+ messages in thread
From: Alex Xu (Hello71) @ 2025-01-13 13:46 UTC (permalink / raw)
To: git, Patrick Steinhardt; +Cc: Alex Xu (Hello71)
config-list is used by builtin/help.c, not libgit. this matches Makefile
dependencies
Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo•ca>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 0064eb64f5..ef3604a17f 100644
--- a/meson.build
+++ b/meson.build
@@ -614,7 +614,7 @@ libgit_sources += custom_target(
env: script_environment,
)
-libgit_sources += custom_target(
+builtin_sources += custom_target(
output: 'config-list.h',
command: [
shell,
--
2.47.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] meson: move config-list from libgit to builtin
2025-01-13 13:46 ` [PATCH] meson: move config-list from libgit to builtin Alex Xu (Hello71)
@ 2025-01-13 14:17 ` Kristoffer Haugsbakk
2025-01-13 15:42 ` Patrick Steinhardt
0 siblings, 1 reply; 3+ messages in thread
From: Kristoffer Haugsbakk @ 2025-01-13 14:17 UTC (permalink / raw)
To: Alex Xu (Hello71), git, Patrick Steinhardt
On Mon, Jan 13, 2025, at 14:46, Alex Xu (Hello71) wrote:
> config-list is used by builtin/help.c, not libgit. this matches Makefile
> dependencies
>
> Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo•ca>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 0064eb64f5..ef3604a17f 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -614,7 +614,7 @@ libgit_sources += custom_target(
> env: script_environment,
> )
>
> -libgit_sources += custom_target(
> +builtin_sources += custom_target(
Looks like the same change is in another patch from today
https://lore.kernel.org/git/20250113-b4-pks-meson-additions-v1-3-97f6a93f691d@pks.im/
--
Kristoffer Haugsbakk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] meson: move config-list from libgit to builtin
2025-01-13 14:17 ` Kristoffer Haugsbakk
@ 2025-01-13 15:42 ` Patrick Steinhardt
0 siblings, 0 replies; 3+ messages in thread
From: Patrick Steinhardt @ 2025-01-13 15:42 UTC (permalink / raw)
To: Kristoffer Haugsbakk; +Cc: Alex Xu (Hello71), git
On Mon, Jan 13, 2025 at 03:17:08PM +0100, Kristoffer Haugsbakk wrote:
> On Mon, Jan 13, 2025, at 14:46, Alex Xu (Hello71) wrote:
> > config-list is used by builtin/help.c, not libgit. this matches Makefile
> > dependencies
> >
> > Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo•ca>
> > ---
> > meson.build | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meson.build b/meson.build
> > index 0064eb64f5..ef3604a17f 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -614,7 +614,7 @@ libgit_sources += custom_target(
> > env: script_environment,
> > )
> >
> > -libgit_sources += custom_target(
> > +builtin_sources += custom_target(
>
> Looks like the same change is in another patch from today
>
> https://lore.kernel.org/git/20250113-b4-pks-meson-additions-v1-3-97f6a93f691d@pks.im/
Yup, indeed :) I'd prefer to go with my series as it also contains a
couple more additions, and because it also fixes the same issue for
"hook-list.h".
Thanks for your contribution!
Patrick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-13 15:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250113134632.21592-1-alex_y_xu.ref@yahoo.ca>
2025-01-13 13:46 ` [PATCH] meson: move config-list from libgit to builtin Alex Xu (Hello71)
2025-01-13 14:17 ` Kristoffer Haugsbakk
2025-01-13 15:42 ` Patrick Steinhardt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox