From: Patrick Steinhardt <ps@pks•im>
To: Meet Soni <meetsoni3017@gmail•com>
Cc: git@vger•kernel.org, shubham.kanodia10@gmail•com
Subject: Re: [RFC PATCH 0/3] refspec: centralize refspec-related logic
Date: Fri, 24 Jan 2025 09:01:38 +0100 [thread overview]
Message-ID: <Z5NI4uUaeHknckJY@pks.im> (raw)
In-Reply-To: <20250122075154.5697-1-meetsoni3017@gmail.com>
On Wed, Jan 22, 2025 at 01:21:51PM +0530, Meet Soni wrote:
> As Patrick pointed out in [1], the logic related to refspec is currently
> split across multiple headers. This patch series addresses that by
> relocating refspec-related logic from remote to refspec for improved
> cohesion.
>
> There are a few functions that seem to be on the borderline. They seem
> to have refspec-related logic, but also contain some elements related
> to remote logic, so I'm unsure whether they should be moved.
> Specifically:
>
> * get_fetch_map()
> * count_refspec_match()
> * check_push_refs()
> * match_push_refs()
>
> [1]: https://lore.kernel.org/git/ZysQvUyxgdRqjvj2@pks.im/
Thanks for this series! A couple comments from my side, but I think that
the overall goal of this series is sensible (well, I seemingly proposed
it at one point, so no surprise there).
Patrick
next prev parent reply other threads:[~2025-01-24 8:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 7:51 [RFC PATCH 0/3] refspec: centralize refspec-related logic Meet Soni
2025-01-22 7:51 ` [RFC PATCH 1/3] refspec: relocate omit_name_by_refspec and related functions Meet Soni
2025-01-24 8:01 ` Patrick Steinhardt
2025-01-22 7:51 ` [RFC PATCH 2/3] refspec: relocate query " Meet Soni
2025-01-24 8:01 ` Patrick Steinhardt
2025-01-22 7:51 ` [RFC PATCH 3/3] refspec: relocate apply_refspecs and related funtions Meet Soni
2025-01-24 8:01 ` Patrick Steinhardt
2025-01-24 8:01 ` Patrick Steinhardt [this message]
2025-01-24 17:25 ` [RFC PATCH 0/3] refspec: centralize refspec-related logic Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5NI4uUaeHknckJY@pks.im \
--to=ps@pks$(echo .)im \
--cc=git@vger$(echo .)kernel.org \
--cc=meetsoni3017@gmail$(echo .)com \
--cc=shubham.kanodia10@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox