From: Patrick Steinhardt <ps@pks•im>
To: Meet Soni <meetsoni3017@gmail•com>
Cc: git@vger•kernel.org, shubham.kanodia10@gmail•com,
Elijah Newren <newren@gmail•com>,
Nipunn Koorapati <nipunn@dropbox•com>,
Jacob Keller <jacob.keller@gmail•com>,
Junio C Hamano <gitster@pobox•com>
Subject: Re: [RFC PATCH 2/3] refspec: relocate query related functions
Date: Fri, 24 Jan 2025 09:01:47 +0100 [thread overview]
Message-ID: <Z5NI60sD8QnQ89W3@pks.im> (raw)
In-Reply-To: <20250122075154.5697-3-meetsoni3017@gmail.com>
On Wed, Jan 22, 2025 at 01:21:53PM +0530, Meet Soni wrote:
> diff --git a/refspec.h b/refspec.h
> index 9556d08bd5..d3c97bfdc5 100644
> --- a/refspec.h
> +++ b/refspec.h
> @@ -1,6 +1,8 @@
> #ifndef REFSPEC_H
> #define REFSPEC_H
>
> +#include "string-list.h"
> +
We can avoid including this header by adding a forward-declaration of
`struct string_list` instead.
> @@ -79,4 +81,9 @@ int omit_name_by_refspec(const char *name, struct refspec *rs);
> int match_name_with_pattern(const char *key, const char *name,
> const char *value, char **result);
>
> +int query_refspecs(struct refspec *rs, struct refspec_item *query);
> +void query_refspecs_multiple(struct refspec *rs,
> + struct refspec_item *query,
> + struct string_list *results);
> +
> #endif /* REFSPEC_H */
It would be nice to add some docs here, too.
Patrick
next prev parent reply other threads:[~2025-01-24 8:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 7:51 [RFC PATCH 0/3] refspec: centralize refspec-related logic Meet Soni
2025-01-22 7:51 ` [RFC PATCH 1/3] refspec: relocate omit_name_by_refspec and related functions Meet Soni
2025-01-24 8:01 ` Patrick Steinhardt
2025-01-22 7:51 ` [RFC PATCH 2/3] refspec: relocate query " Meet Soni
2025-01-24 8:01 ` Patrick Steinhardt [this message]
2025-01-22 7:51 ` [RFC PATCH 3/3] refspec: relocate apply_refspecs and related funtions Meet Soni
2025-01-24 8:01 ` Patrick Steinhardt
2025-01-24 8:01 ` [RFC PATCH 0/3] refspec: centralize refspec-related logic Patrick Steinhardt
2025-01-24 17:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5NI60sD8QnQ89W3@pks.im \
--to=ps@pks$(echo .)im \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jacob.keller@gmail$(echo .)com \
--cc=meetsoni3017@gmail$(echo .)com \
--cc=newren@gmail$(echo .)com \
--cc=nipunn@dropbox$(echo .)com \
--cc=shubham.kanodia10@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox