From: Patrick Steinhardt <ps@pks•im>
To: Usman Akinyemi <usmanakinyemi202@gmail•com>
Cc: git@vger•kernel.org, christian.couder@gmail•com,
gitster@pobox•com, johncai86@gmail•com, me@ttaylorr•com,
phillip.wood123@gmail•com, shejialuo@gmail•com,
Christian Couder <chriscool@tuxfamily•org>
Subject: Re: [PATCH 2/9] builtin/verify-tag: stop using `the_repository`
Date: Thu, 20 Mar 2025 08:21:48 +0100 [thread overview]
Message-ID: <Z9vCDFRUG7IzU_AG@pks.im> (raw)
In-Reply-To: <20250318115912.2978992-3-usmanakinyemi202@gmail.com>
On Tue, Mar 18, 2025 at 05:28:54PM +0530, Usman Akinyemi wrote:
> diff --git a/t/t7030-verify-tag.sh b/t/t7030-verify-tag.sh
> index 6f526c37c2..2c147072c1 100755
> --- a/t/t7030-verify-tag.sh
> +++ b/t/t7030-verify-tag.sh
> @@ -7,6 +7,13 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
> . ./test-lib.sh
> . "$TEST_DIRECTORY/lib-gpg.sh"
>
> +test_expect_success GPG 'verify-tag does not crash with -h' '
> + test_expect_code 129 git verify-tag -h >usage &&
> + test_grep "[Uu]sage: git verify-tag " usage &&
> + test_expect_code 129 nongit git verify-tag -h >usage &&
> + test_grep "[Uu]sage: git verify-tag " usage
> +'
> +
> test_expect_success GPG 'create signed tags' '
> echo 1 >file && git add file &&
> test_tick && git commit -m initial &&
We have "t1517-outside-repo.sh". Maybe it would preferable to add tests
like these to that test suite instead?
Patrick
next prev parent reply other threads:[~2025-03-20 7:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 11:58 [PATCH 0/9] remove unnecessary if statement Usman Akinyemi
2025-03-18 11:58 ` [PATCH 1/9] config: teach repo_config to allow `repo` to be NULL Usman Akinyemi
2025-03-20 7:21 ` Patrick Steinhardt
2025-03-21 6:56 ` Usman Akinyemi
2025-03-18 11:58 ` [PATCH 2/9] builtin/verify-tag: stop using `the_repository` Usman Akinyemi
2025-03-20 7:21 ` Patrick Steinhardt [this message]
2025-03-18 11:58 ` [PATCH 3/9] builtin/verify-commit: " Usman Akinyemi
2025-03-18 11:58 ` [PATCH 4/9] builtin/send-pack: " Usman Akinyemi
2025-03-18 11:58 ` [PATCH 5/9] builtin/pack-refs: " Usman Akinyemi
2025-03-18 11:58 ` [PATCH 6/9] builtin/ls-files: " Usman Akinyemi
2025-03-18 11:58 ` [PATCH 7/9] builtin/for-each-ref: " Usman Akinyemi
2025-03-18 11:59 ` [PATCH 8/9] builtin/checkout-index: " Usman Akinyemi
2025-03-18 11:59 ` [PATCH 9/9] builtin/update-server-info: remove unnecessary if statement Usman Akinyemi
2025-03-20 7:21 ` Patrick Steinhardt
2025-03-21 7:00 ` Usman Akinyemi
2025-03-18 20:21 ` [PATCH 0/9] " Junio C Hamano
2025-03-19 3:53 ` Usman Akinyemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9vCDFRUG7IzU_AG@pks.im \
--to=ps@pks$(echo .)im \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=johncai86@gmail$(echo .)com \
--cc=me@ttaylorr$(echo .)com \
--cc=phillip.wood123@gmail$(echo .)com \
--cc=shejialuo@gmail$(echo .)com \
--cc=usmanakinyemi202@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox