From: Junio C Hamano <gitster@pobox•com>
To: Usman Akinyemi <usmanakinyemi202@gmail•com>
Cc: git@vger•kernel.org, christian.couder@gmail•com,
johncai86@gmail•com, me@ttaylorr•com,
phillip.wood123@gmail•com, ps@pks•im, shejialuo@gmail•com
Subject: Re: [PATCH 0/9] remove unnecessary if statement
Date: Tue, 18 Mar 2025 13:21:49 -0700 [thread overview]
Message-ID: <xmqqmsdi144i.fsf@gitster.g> (raw)
In-Reply-To: <20250318115912.2978992-1-usmanakinyemi202@gmail.com> (Usman Akinyemi's message of "Tue, 18 Mar 2025 17:28:52 +0530")
Usman Akinyemi <usmanakinyemi202@gmail•com> writes:
> In an earlier patch[1] which has been merged to the master,
> We checked `repo` is not NULL before making call to `repo_config()`.
> Later, in another patch series[2] which has been merged to next,
> `repo_config()` was taught to allow `repo` to be NULL.
>
> So there is not need for checking if the `repo` is NULL before calling
> repo_config() in the earlier patch.
OK, that sounds good.
Are we confident that our half-hearted choice of "there is no repo,
so just do a very-early-config thing" is appropriate for any code
paths?
At least we should be perfectly happy with that choice applied to
all of these code paths touched by this series.
> Note, I have already sent the first 8 patches in [2] but, the 9th
> patch depends on the first patch of that series.
So, is this [v2 0/9] of ua/some-builtins-wo-the-repository?
I think that topic has long been merged to 'next', and it is way too
late to do a wholesale replacement like this.
> [1] https://public-inbox.org/git/20250210181103.3609495-1-usmanakinyemi202@gmail.com/
> [2] https://public-inbox.org/git/20250307233543.1721552-1-usmanakinyemi202@gmail.com/
>
> Usman Akinyemi (9):
> config: teach repo_config to allow `repo` to be NULL
> builtin/verify-tag: stop using `the_repository`
> builtin/verify-commit: stop using `the_repository`
> builtin/send-pack: stop using `the_repository`
> builtin/pack-refs: stop using `the_repository`
> builtin/ls-files: stop using `the_repository`
> builtin/for-each-ref: stop using `the_repository`
> builtin/checkout-index: stop using `the_repository`
> builtin/update-server-info: remove unnecessary if statement
>
> builtin/checkout-index.c | 43 ++++++++++++++++-----------------
> builtin/for-each-ref.c | 5 ++--
> builtin/ls-files.c | 32 ++++++++++++------------
> builtin/pack-refs.c | 8 +++---
> builtin/send-pack.c | 7 +++---
> builtin/update-server-info.c | 4 +--
> builtin/verify-commit.c | 13 +++++-----
> builtin/verify-tag.c | 7 +++---
> config.c | 4 +++
> config.h | 9 +++++++
> t/t0610-reftable-basics.sh | 7 ++++++
> t/t2006-checkout-index-basic.sh | 7 ++++++
> t/t3004-ls-files-basic.sh | 7 ++++++
> t/t5400-send-pack.sh | 7 ++++++
> t/t6300-for-each-ref.sh | 7 ++++++
> t/t7030-verify-tag.sh | 7 ++++++
> t/t7510-signed-commit.sh | 7 ++++++
> 17 files changed, 118 insertions(+), 63 deletions(-)
next prev parent reply other threads:[~2025-03-18 20:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 11:58 [PATCH 0/9] remove unnecessary if statement Usman Akinyemi
2025-03-18 11:58 ` [PATCH 1/9] config: teach repo_config to allow `repo` to be NULL Usman Akinyemi
2025-03-20 7:21 ` Patrick Steinhardt
2025-03-21 6:56 ` Usman Akinyemi
2025-03-18 11:58 ` [PATCH 2/9] builtin/verify-tag: stop using `the_repository` Usman Akinyemi
2025-03-20 7:21 ` Patrick Steinhardt
2025-03-18 11:58 ` [PATCH 3/9] builtin/verify-commit: " Usman Akinyemi
2025-03-18 11:58 ` [PATCH 4/9] builtin/send-pack: " Usman Akinyemi
2025-03-18 11:58 ` [PATCH 5/9] builtin/pack-refs: " Usman Akinyemi
2025-03-18 11:58 ` [PATCH 6/9] builtin/ls-files: " Usman Akinyemi
2025-03-18 11:58 ` [PATCH 7/9] builtin/for-each-ref: " Usman Akinyemi
2025-03-18 11:59 ` [PATCH 8/9] builtin/checkout-index: " Usman Akinyemi
2025-03-18 11:59 ` [PATCH 9/9] builtin/update-server-info: remove unnecessary if statement Usman Akinyemi
2025-03-20 7:21 ` Patrick Steinhardt
2025-03-21 7:00 ` Usman Akinyemi
2025-03-18 20:21 ` Junio C Hamano [this message]
2025-03-19 3:53 ` [PATCH 0/9] " Usman Akinyemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmsdi144i.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johncai86@gmail$(echo .)com \
--cc=me@ttaylorr$(echo .)com \
--cc=phillip.wood123@gmail$(echo .)com \
--cc=ps@pks$(echo .)im \
--cc=shejialuo@gmail$(echo .)com \
--cc=usmanakinyemi202@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox