From: Andrew Kreimer <algonell@gmail•com>
To: Taylor Blau <me@ttaylorr•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] t: fix typos
Date: Fri, 18 Oct 2024 19:51:32 +0300 [thread overview]
Message-ID: <ZxKSFBl_pV2r99dY@void.void> (raw)
In-Reply-To: <ZxFyKXDCJkRZYYQY@nand.local>
On Thu, Oct 17, 2024 at 04:23:05PM -0400, Taylor Blau wrote:
> Please do not base new topics on 'seen', as it is likely to change
> day-to-day.
>
Noted, thank you.
> > @@ -117,7 +117,7 @@ do
> > git config extensions.objectformat $hash &&
> > git config extensions.compatobjectformat $(compat_hash $hash) &&
> > git config gpg.program $TEST_DIRECTORY/t1016/gpg &&
> > - echo "Hellow World!" > hello &&
> > + echo "Hello World!" > hello &&
>
> Not the fault of this patch, but there is a style issue here that there
> should not be a space between '>' and 'hello' (i.e. it should read
> '>hello', not '> hello').
>
Do you mean that '> more' and '> another' should be handled similarly?
> Likewise with the 'git config' use above should be test_config, etc. But
> this patch does not need to care about that, since it did not introduce
> those issues in the first place.
>
Will try to address this one.
next prev parent reply other threads:[~2024-10-18 16:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 11:28 [PATCH] t: fix typos Andrew Kreimer
2024-10-17 20:23 ` Taylor Blau
2024-10-18 16:51 ` Andrew Kreimer [this message]
2024-10-18 16:58 ` Kristoffer Haugsbakk
2024-10-18 18:03 ` Andrew Kreimer
2024-10-18 21:05 ` Taylor Blau
2024-10-18 21:06 ` Taylor Blau
2024-10-18 21:41 ` Taylor Blau
2024-10-19 13:08 ` Andrew Kreimer
-- strict thread matches above, loose matches on Subject: below --
2024-10-23 17:01 Andrew Kreimer
2024-10-23 18:00 ` Kristoffer Haugsbakk
2024-10-23 18:33 ` Taylor Blau
2024-10-24 11:44 ` Andrew Kreimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxKSFBl_pV2r99dY@void.void \
--to=algonell@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=me@ttaylorr$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox