From: "brian m. carlson" <sandals@crustytoothpaste•net>
To: Carlo Arenas <carenas@gmail•com>
Cc: Brad Smith <brad@comstyle•com>, git@vger•kernel.org
Subject: Re: [PATCH v2] config.mak.uname: update settings for FreeBSD
Date: Thu, 12 Jun 2025 16:48:49 +0000 [thread overview]
Message-ID: <aEsE8S90fJSr9Or5@fruit.crustytoothpaste.net> (raw)
In-Reply-To: <CAPUEspguEY+e-J0dMA2EdDgu=t4fK5ASS13Jfp_Mgwiq3Rtd0Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]
On 2025-06-12 at 13:52:03, Carlo Arenas wrote:
> On Thu, Jun 12, 2025 at 12:36:46AM -0800, Brad Smith wrote:
> >
> > FreeBSD 6.0 has memmem().
>
> but AFAIK it was buggy, uncompatible with the "standard" and
> didn't perform that well, at least until FreeBSD 12.
>
> assuming that the system version is indeed faster than the
> one provided with git (which should be true but worth testing)
> then it might be better to only enable this for later versions?
FreeBSD 11.4 (the last version of FreeBSD 11) went end of life in
September 2021, so nobody should be using it since it hasn't had
security support since then. And it's even been functional (but slow)
since FreeBSD 11.0, and 10.4 went EOL in 2018. So users shouldn't
actually be experiencing any actual functionality problems since then.
I don't think it's a big deal for people who want to use an obsolete OS
(which, to be clear, I'm not encouraging) to tweak the Makefile knobs a
bit.
> > With making 6.0 the minimum version drop bits for supporting
> > FreeBSD 4.x.
>
> FreeBSD 4.x is no longer supported and wouldn't even build a
> current git, since it predates C99 and is missing POSIX
> compatibility with what we require (ex: no statvfs)
I definitely think getting rid of FreeBSD 4 support is fine. It doesn't
even support AMD64, so as a practical matter it wouldn't be useful on
any sort of modern hardware.
--
brian m. carlson (they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2025-06-12 16:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 13:52 [PATCH v2] config.mak.uname: update settings for FreeBSD Carlo Arenas
2025-06-12 16:48 ` brian m. carlson [this message]
2025-06-12 21:31 ` Carlo Marcelo Arenas Belón
2025-06-12 21:51 ` [PATCH v3] " Junio C Hamano
2025-06-12 22:30 ` Carlo Marcelo Arenas Belón
2025-06-12 22:37 ` Junio C Hamano
2025-07-02 9:37 ` [PATCH v4 0/2] " Carlo Marcelo Arenas Belón
2025-07-02 9:37 ` [PATCH v4 1/2] config.mak.uname: set NO_MEMMEM only for functional version Carlo Marcelo Arenas Belón
2025-07-02 9:37 ` [PATCH v4 2/2] build: retire NO_UINTMAX_T Carlo Marcelo Arenas Belón
2025-07-02 16:21 ` [PATCH v4 0/2] config.mak.uname: update settings for FreeBSD Junio C Hamano
2025-06-12 16:52 ` [PATCH v2] " Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2025-06-12 4:36 Brad Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEsE8S90fJSr9Or5@fruit.crustytoothpaste.net \
--to=sandals@crustytoothpaste$(echo .)net \
--cc=brad@comstyle$(echo .)com \
--cc=carenas@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox